Skip to content

Bugfix/66229 processing empty dictionary items#86394

Closed
Maximys wants to merge 2 commits into
dotnet:mainfrom
Maximys:bugfix/66229-processing-empty-dictionary-items
Closed

Bugfix/66229 processing empty dictionary items#86394
Maximys wants to merge 2 commits into
dotnet:mainfrom
Maximys:bugfix/66229-processing-empty-dictionary-items

Conversation

@Maximys

@Maximys Maximys commented May 17, 2023

Copy link
Copy Markdown
Contributor

Fixes of #66229

@ghost ghost added area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member labels May 17, 2023
@ghost

ghost commented May 17, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes of #66229

Author: Maximys
Assignees: -
Labels:

area-Extensions-Configuration

Milestone: -

@tarekgh

tarekgh commented May 17, 2023

Copy link
Copy Markdown
Member

@Maximys we try to minimize the changes that go to the binder. please revert the refactoring and keep only the changes that needed for the fix.

CC @layomia

@tarekgh tarekgh added needs-author-action An issue or pull request that requires more info or actions from the author. NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels May 17, 2023
@layomia

layomia commented May 17, 2023

Copy link
Copy Markdown
Contributor

we try to minimize the changes that go to the binder.

This is due to ongoing development of the config binding generator (#44493). We need a stable baseline for feature parity (i.e this reflection implementation).

@tarekgh

tarekgh commented May 18, 2023

Copy link
Copy Markdown
Member

@Maximys thanks for your PR. I am going to temporarily close this one till you update the code and address all failures you see in the CI.

@tarekgh tarekgh closed this May 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants