[mono] Fix sorting custom attributes in ILStrip#88435
Merged
Merged
Conversation
The change in dotnet#87923 was subtly wrong, the problem is that RID on a Cecil metadata token masks out the token type. We actually have to reconstruct the custom attribute coded-index.
ghost
added
the
needs-area-label
akoeplinger
added
area-VM-meta-mono
and removed
needs-area-label
Member
Author
|
/backport to release/7.0-staging |
Contributor
|
Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5467993606 |
lambdageek
approved these changes
Jul 5, 2023
Member
|
Thanks for the quick fix. cc @jandupej |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in #87923 was subtly wrong, the problem is that RID on a Cecil metadata token masks out the token type. We actually have to reconstruct the custom attribute coded-index.
Credit to @lambdageek for the fix.