Skip to content

[7.0] Backport "Fix MSBuild integration for the host build with CMake 3.26"#88809

Merged
carlossanlop merged 2 commits into
dotnet:release/7.0-stagingfrom
carlossanlop:FixCmake
Jul 14, 2023
Merged

[7.0] Backport "Fix MSBuild integration for the host build with CMake 3.26"#88809
carlossanlop merged 2 commits into
dotnet:release/7.0-stagingfrom
carlossanlop:FixCmake

Conversation

@carlossanlop

Copy link
Copy Markdown
Contributor

Backporting commit 2f20812 from this PR: #88208

From a conversation with @hoyosjs, this should fix #88806

There was other commit in the PR, but it just added a comment. Do we need it?

@carlossanlop carlossanlop added the area-Infrastructure-coreclr Only use for closed issues label Jul 13, 2023
@carlossanlop carlossanlop self-assigned this Jul 13, 2023
@ghost

ghost commented Jul 13, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Backporting commit 2f20812 from this PR: #88208

From a conversation with @hoyosjs, this should fix #88806

There was other commit in the PR, but it just added a comment. Do we need it?

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure-coreclr

Milestone: -

Comment thread src/tests/Interop/IJW/CopyConstructorMarshaler/CMakeLists.txt
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Jul 13, 2023
@carlossanlop

Copy link
Copy Markdown
Contributor Author

@hoyosjs @jkoritzinsky unfortunately, it didn't work. Failure is still happening: https://github.com/dotnet/runtime/pull/88809/checks?check_run_id=15001712296

Comment thread eng/native/ijw/IJW.cmake Outdated
@carlossanlop carlossanlop merged commit 3aae244 into dotnet:release/7.0-staging Jul 14, 2023
@carlossanlop carlossanlop deleted the FixCmake branch July 14, 2023 16:13
@radical radical mentioned this pull request Aug 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclr Only use for closed issues Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants