[mono][interp] Fix memory leaks for interpreted dynamic methods.#88892
Merged
Conversation
vargaz
commented
Jul 14, 2023
vargaz
commented
Contributor
- Add a mempool to MonoDynamicMethod.
- Modify the intepreter code to allocate from this mempool when interpreting dynamic methods.
vargaz
requested review from
BrzVlad,
SamMonoRT,
kotlarmilos,
lambdageek and
thaystg
as code owners
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue Details
|
Contributor
Author
|
Ref: #87078 |
Contributor
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
force-pushed
the
interp-memory
branch
3 times, most recently
from
136c83d to
066690c
Compare
Contributor
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
force-pushed
the
interp-memory
branch
3 times, most recently
from
14d5cd5 to
968f4c2
Compare
This was referenced Jul 14, 2023
vargaz
force-pushed
the
interp-memory
branch
2 times, most recently
from
97702bb to
c5b7223
Compare
vargaz
force-pushed
the
interp-memory
branch
7 times, most recently
from
b64f58f to
df47797
Compare
kg
reviewed
Jul 17, 2023
…oDynamicMethod is allocated instead of a MonoMethodWrapper.
* Add a mempool to MonoDynamicMethod. * Modify the intepreter code to allocate from this mempool when interpreting dynamic methods.
BrzVlad
approved these changes
Jul 18, 2023
Member
|
I suspect this might have caused crashes like I am able to reproduce with moderate difficulty. I'm taking a look into it. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.