Split off system libraries into a separate ItemGroup#89916
Merged
Conversation
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsShould help with #88294 (comment). We could try to put more arguments on the ExtraLinkerArg plan but I wanted to keep the diff short and reviewable for now. Cc @dotnet/ilc-contrib
|
filipnavara
approved these changes
Aug 3, 2023
am11
reviewed
Aug 3, 2023
Comment on lines
141
to
143
| <LinkerArg Include="-L/usr/lib/swift" Condition="'$(_targetOS)' == 'osx'" /> | ||
| <LinkerArg Include="@(StaticICULibs)" Condition="'$(StaticICULinking)' == 'true'" /> | ||
| <LinkerArg Include="@(StaticSslLibs)" Condition="'$(StaticOpenSslLinking)' == 'true'" /> |
Member
Author
There was a problem hiding this comment.
The first one is capital L so it doesn't feel like it fits either of the new ItemGroups. Would need a NativeSystemLibraryPath
Breaking up the static ICU/SSL weirdness would be more diffs so it's the same reasoning as "We could try to put more arguments on the ExtraLinkerArg plan but I wanted to keep the diff short and reviewable for now."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help with #88294 (comment).
We could try to put more arguments on the ExtraLinkerArg plan but I wanted to keep the diff short and reviewable for now.
Cc @dotnet/ilc-contrib