Skip to content

Use Unsafe.WriteUnaligned in BitConverter.GetBytes #91639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xtqqczze wants to merge 7 commits into from
Closed

Use Unsafe.WriteUnaligned in BitConverter.GetBytes #91639

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c120d8
Reduce IL size for `BitConverter.GetBytes`
xtqqczze Sep 5, 2023
5241e2b
Avoid spilling floating point argument
xtqqczze Sep 6, 2023
cbe9a08
Use unsigned casts
xtqqczze Sep 7, 2023
039c509
Use `AggressiveInlining`
xtqqczze Sep 7, 2023
f836959
Revert to 9c120d8 and add `AggressiveInlining`
xtqqczze Sep 10, 2023
377f9a0
fixup!
xtqqczze Sep 10, 2023
e7cd0dd
Add `AggressiveInlining` to `GetBytes(bool)`
xtqqczze Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions src/libraries/System.Private.CoreLib/src/System/BitConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public static class BitConverter
/// </summary>
/// <param name="value">A Boolean value.</param>
/// <returns>A byte array with length 1.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(bool value)
{
byte[] r = new byte[1];
Expand Down Expand Up @@ -56,10 +57,11 @@ public static bool TryWriteBytes(Span<byte> destination, bool value)
/// </summary>
/// <param name="value">A Char value.</param>
/// <returns>An array of bytes with length 2.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(char value)
{
byte[] bytes = new byte[sizeof(char)];
Unsafe.As<byte, char>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand All @@ -83,10 +85,11 @@ public static bool TryWriteBytes(Span<byte> destination, char value)
/// </summary>
/// <param name="value">The number to convert.</param>
/// <returns>An array of bytes with length 2.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(short value)
{
byte[] bytes = new byte[sizeof(short)];
Unsafe.As<byte, short>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand All @@ -110,10 +113,11 @@ public static bool TryWriteBytes(Span<byte> destination, short value)
/// </summary>
/// <param name="value">The number to convert.</param>
/// <returns>An array of bytes with length 4.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(int value)
{
byte[] bytes = new byte[sizeof(int)];
Unsafe.As<byte, int>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand All @@ -137,10 +141,11 @@ public static bool TryWriteBytes(Span<byte> destination, int value)
/// </summary>
/// <param name="value">The number to convert.</param>
/// <returns>An array of bytes with length 8.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(long value)
{
byte[] bytes = new byte[sizeof(long)];
Unsafe.As<byte, long>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand All @@ -165,10 +170,11 @@ public static bool TryWriteBytes(Span<byte> destination, long value)
/// <param name="value">The number to convert.</param>
/// <returns>An array of bytes with length 2.</returns>
[CLSCompliant(false)]
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(ushort value)
{
byte[] bytes = new byte[sizeof(ushort)];
Unsafe.As<byte, ushort>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand All @@ -194,10 +200,11 @@ public static bool TryWriteBytes(Span<byte> destination, ushort value)
/// <param name="value">The number to convert.</param>
/// <returns>An array of bytes with length 4.</returns>
[CLSCompliant(false)]
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(uint value)
{
byte[] bytes = new byte[sizeof(uint)];
Unsafe.As<byte, uint>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand All @@ -223,10 +230,11 @@ public static bool TryWriteBytes(Span<byte> destination, uint value)
/// <param name="value">The number to convert.</param>
/// <returns>An array of bytes with length 8.</returns>
[CLSCompliant(false)]
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(ulong value)
{
byte[] bytes = new byte[sizeof(ulong)];
Unsafe.As<byte, ulong>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand All @@ -251,10 +259,11 @@ public static bool TryWriteBytes(Span<byte> destination, ulong value)
/// </summary>
/// <param name="value">The number to convert.</param>
/// <returns>An array of bytes with length 2.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static unsafe byte[] GetBytes(Half value)
{
byte[] bytes = new byte[sizeof(Half)];
Unsafe.As<byte, Half>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand All @@ -278,10 +287,11 @@ public static unsafe bool TryWriteBytes(Span<byte> destination, Half value)
/// </summary>
/// <param name="value">The number to convert.</param>
/// <returns>An array of bytes with length 4.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(float value)
{
byte[] bytes = new byte[sizeof(float)];
Unsafe.As<byte, float>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand All @@ -305,10 +315,11 @@ public static bool TryWriteBytes(Span<byte> destination, float value)
/// </summary>
/// <param name="value">The number to convert.</param>
/// <returns>An array of bytes with length 8.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte[] GetBytes(double value)
{
byte[] bytes = new byte[sizeof(double)];
Unsafe.As<byte, double>(ref bytes[0]) = value;
Unsafe.WriteUnaligned(ref MemoryMarshal.GetArrayDataReference(bytes), value);
return bytes;
}

Expand Down