Skip to content

[release/8.0] Fix Dispose and SendData Race on Http3 Test#91690

Merged
carlossanlop merged 2 commits into
release/8.0from
backport/pr-91291-to-release/8.0
Sep 11, 2023
Merged

[release/8.0] Fix Dispose and SendData Race on Http3 Test#91690
carlossanlop merged 2 commits into
release/8.0from
backport/pr-91291-to-release/8.0

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Backport of #91291 to release/8.0

Fixes #87552

/cc @liveans

Customer Impact

Test only change to decrease noise in CI.
Fixes test System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.ServerSendsTrailingHeaders_Success, which failed 3x per day (but passed on rerun).

Testing

CI in main had no hits in 2 days - previously failed 3x per day.

Risk

No risk, the test only change

@ghost ghost added the area-System.Net.Http label Sep 6, 2023
@ghost

ghost commented Sep 6, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91291 to release/8.0

/cc @liveans

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@liveans liveans requested review from a team and karelz September 6, 2023 19:41
@liveans

liveans commented Sep 7, 2023

Copy link
Copy Markdown
Member

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@liveans

liveans commented Sep 11, 2023

Copy link
Copy Markdown
Member

Failures are unrelated to this PR.
Mostly related to #91705 and the rest of them are also unrelated.

Failures (updated by @karelz):

Rerunning the failures

@karelz

karelz commented Sep 11, 2023

Copy link
Copy Markdown
Member

Test only change, I approve - @artl93 ready for your approval

@karelz karelz added the Servicing-consider Issue for next servicing release review label Sep 11, 2023
@artl93

artl93 commented Sep 11, 2023

Copy link
Copy Markdown
Member

M2 approved.

@karelz karelz added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 11, 2023
@karelz

karelz commented Sep 11, 2023

Copy link
Copy Markdown
Member

Adding Servicing-Approved label per @artl93's approval above.

@artl93

artl93 commented Sep 11, 2023

Copy link
Copy Markdown
Member

Adding Servicing-Approved label per @artl93's approval above.

Yes, thank you!

@carlossanlop carlossanlop merged commit 64c5aae into release/8.0 Sep 11, 2023
@carlossanlop carlossanlop deleted the backport/pr-91291-to-release/8.0 branch September 11, 2023 23:17
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Net.Http Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants