Skip to content

Use the native cross compilers on win-arm64#92443

Merged
lewing merged 1 commit into
dotnet:mainfrom
lewing:use-arm64-native-cross
Oct 28, 2023
Merged

Use the native cross compilers on win-arm64#92443
lewing merged 1 commit into
dotnet:mainfrom
lewing:use-arm64-native-cross

Conversation

@lewing

@lewing lewing commented Sep 21, 2023

Copy link
Copy Markdown
Member

No description provided.

@ghost ghost added the area-Build-mono label Sep 21, 2023
@ghost ghost assigned lewing Sep 21, 2023
@lewing lewing requested a review from steveisok September 21, 2023 23:13
@steveisok

steveisok commented Sep 21, 2023

Copy link
Copy Markdown
Member

This is pending win-arm64 cross compiler support from @directhex.

@directhex

directhex commented Sep 22, 2023 via email

Copy link
Copy Markdown
Contributor

@lewing

lewing commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

are the packages being built and published? should we turn this on in head and let people try out the builds? we could stand up a wbt win-arm64 lane for smoke tests if we have hosts

@steveisok

steveisok commented Sep 22, 2023

Copy link
Copy Markdown
Member

We will need to do an official build to validate. I do think there's value in having this in main.

@ghost ghost closed this Oct 22, 2023
@ghost

ghost commented Oct 22, 2023

Copy link
Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@steveisok steveisok reopened this Oct 23, 2023
@lewing

lewing commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

kicked off an official build, we'll see how it goes

https://dev.azure.com/dnceng/internal/_build/results?buildId=2303077&view=results

@lewing

lewing commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@steveisok looks green on the official build, should we merge and try it out?

@lewing lewing marked this pull request as ready for review October 27, 2023 23:58
@lewing lewing requested a review from radical as a code owner October 27, 2023 23:58
@steveisok

steveisok commented Oct 28, 2023

Copy link
Copy Markdown
Member

@steveisok looks green on the official build, should we merge and try it out?

YOLO!

@lewing lewing merged commit a153c19 into dotnet:main Oct 28, 2023
@lewing lewing deleted the use-arm64-native-cross branch October 28, 2023 00:02
@akoeplinger

akoeplinger commented Oct 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

FYI this was already done in #89651. The commit in main from this PR shows 0 changes 😄

liveans pushed a commit to liveans/dotnet-runtime that referenced this pull request Nov 9, 2023
@lewing @liveans
Use the native cross compilers on win-arm64 (dotnet#92443)
668b7af
@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

@steveisok steveisok Awaiting requested review from steveisok

Assignees

@lewing lewing

Labels

area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lewing @steveisok @directhex @akoeplinger @radical