Skip to content

[MT][browser] Disable new CI failures on library MT tests#93224

Merged
ilonatommy merged 4 commits into
dotnet:mainfrom
ilonatommy:91536-follow-up
Oct 11, 2023
Merged

[MT][browser] Disable new CI failures on library MT tests#93224
ilonatommy merged 4 commits into
dotnet:mainfrom
ilonatommy:91536-follow-up

Conversation

@ilonatommy

@ilonatommy ilonatommy commented Oct 9, 2023

Copy link
Copy Markdown
Member
  • Block Wasm.Browser.Threads.Minimal.Sample.csproj for MT

  • Move issues connected with MT exclusions to be blocked only in MT mode.

  • Add project exclusion for Microsoft.Extensions.DependencyInjection.Tests

  • Fixing fail: [out of order message from the browser]: http://127.0.0.1:33323/_framework/dotnet.js 2 WebSocket connection to 'ws://127.0.0.1:33323/_framework/dotnet.native.worker.js/console' failed: Error during WebSocket handshake: Unexpected response code: 404

@ghost

ghost commented Oct 9, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • We were planning to switch off shouldContinueOnError after a few weeks from merging [browser][MT] enable all MT library tests on the runtime CI pipeline #91536 if it will not be failing after disabling.
  • Fixing fail: [out of order message from the browser]: http://127.0.0.1:33323/_framework/dotnet.js 2 WebSocket connection to 'ws://127.0.0.1:33323/_framework/dotnet.native.worker.js/console' failed: Error during WebSocket handshake: Unexpected response code: 404 log
Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-VM-threading-mono

Milestone: -

@pavelsavara

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Oct 9, 2023

Copy link
Copy Markdown
Member

How often has this run recently, and how often has it failed?

@pavelsavara

Copy link
Copy Markdown
Member

How often has this run recently, and how often has it failed?

It failed "silently" for me. I have not noticed that there is "organge" lane. I want it to really fail when I do /azp run runtime-wasm

@radical

radical commented Oct 9, 2023

Copy link
Copy Markdown
Member

'runtime-wasm' will be red then.

@pavelsavara

Copy link
Copy Markdown
Member

'runtime-wasm' will be red then.

Right, that's what we want to anything that was not already marked active issue by Ilona in #91536.

Am I missing something ?

@ilonatommy

Copy link
Copy Markdown
Member Author

This PR needs adding a blocking for Wasm.Browser.Threads.Minimal.Sample and Microsoft.Extensions.DependencyInjection.Tests, they might have been overlooked in the big blocking PR (I will add it). Beyond that, nothing else failed. If a new failure will arise, we will at least notice it thanks to this change.

@radical

radical commented Oct 9, 2023

Copy link
Copy Markdown
Member

'runtime-wasm' will be red then.

Right, that's what we want to anything that was not already marked active issue by Ilona in #91536.

Am I missing something ?

Has the job been green for few weeks when there were no PR introduced mt failures? That's what I'm talking about. It shouldn't randomly fail, else we would start getting merges on red and failures getting ignored because users aren't sure whether the failures are expected. A red pipeline on PRs that did not introduce mt failures would be counterproductive.

@radical

radical commented Oct 9, 2023

Copy link
Copy Markdown
Member

This PR needs adding a blocking for Wasm.Browser.Threads.Minimal.Sample and Microsoft.Extensions.DependencyInjection.Tests, they might have been overlooked in the big blocking PR (I will add it). Beyond that, nothing else failed. If a new failure will arise, we will at least notice it thanks to this change.

Then it hasn't been green/stable for few weeks.

@ilonatommy

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/libraries/tests.proj Outdated

@radical radical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this yet. We should have couple of weeks worth of builds where the job has been green, before we merge.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Oct 9, 2023
Comment thread eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Oct 9, 2023
@ilonatommy

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

Copy link
Copy Markdown
Member

Please don't merge this yet. We should have couple of weeks worth of builds where the job has been green, before we merge.

In that case we need to make the test run much more often. What we have now is useless waiting without any observability. Do you have any proposal @radical ?

@radical

radical commented Oct 11, 2023

Copy link
Copy Markdown
Member

Please don't merge this yet. We should have couple of weeks worth of builds where the job has been green, before we merge.

In that case we need to make the test run much more often. What we have now is useless waiting without any observability. Do you have any proposal @radical ?

The test failures are observable, just that they won't show up as failures in github. Open the azdo build and you can see the failures, and all the details.

@ilonatommy

Copy link
Copy Markdown
Member Author

Let's merge at least these fixes for now. Failures are unrelated.

@radical

radical commented Oct 11, 2023

Copy link
Copy Markdown
Member

Let's merge at least these fixes for now.

👍 Please update the PR title, and description to match.

@ilonatommy ilonatommy changed the title [MT][browser] Allow CI failures on library MT tests [MT][browser] Disable new CI failures on library MT tests Oct 11, 2023
@radical

radical commented Oct 11, 2023

Copy link
Copy Markdown
Member

Also, please open an issue for the error that is unrelated, and isn't being flagged by build analysis.

@ilonatommy ilonatommy merged commit 7f63b6b into dotnet:main Oct 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-VM-threading-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants