Skip to content

[main] Update dependencies from dotnet/installer - #93921

Merged
radical merged 2 commits into
mainfrom
darc-main-760105b2-2776-43d2-ad4f-a45fc59f5f30
Oct 24, 2023
Merged

[main] Update dependencies from dotnet/installer#93921
radical merged 2 commits into
mainfrom
darc-main-760105b2-2776-43d2-ad4f-a45fc59f5f30

Conversation

@dotnet-maestro

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/installer

  • Subscription: 2a4e5111-6978-401f-68a5-08dba3b24dbe
  • Build: 20231024.2
  • Date Produced: October 24, 2023 9:31:54 AM UTC
  • Commit: ba5b9001a0a61ddff041886745b0b395623a9227
  • Branch: refs/heads/main

…231024.2

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-alpha.1.23522.3 -> To Version 9.0.100-alpha.1.23524.2
@ghost ghost added the area-codeflow for labeling automated codeflow label Oct 24, 2023
@radical

radical commented Oct 24, 2023

Copy link
Copy Markdown
Member

LazyLoadingTest.cs(15,9): Trim analysis error IL2026: LazyLoadingTest.Run(): Using member 'System.Text.Json.JsonSerializer.Serialize<TValue>(TValue, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.

@maraf New analyzer breaking the TestAppScenarios* tests.

update: log

@radical radical self-assigned this Oct 24, 2023
`[] /root/helix/work/workitem/e/wbt/AppSettingsTests_haqswfqc_rzt/LazyLoadingTest.cs(15,9): Trim analysis error IL2026: LazyLoadingTest.Run(): Using member 'System.Text.Json.JsonSerializer.Serialize<TValue>(TValue, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [/root/helix/work/workitem/e/wbt/AppSettingsTests_haqswfqc_rzt/WasmBasicTestApp.csproj]`
@radical

radical commented Oct 24, 2023

Copy link
Copy Markdown
Member

Failing tests are #93522 .

@maraf please feel free to change LazyLoadingTests.cs if you want to remove the warning suppression.

@radical
radical merged commit 08903c0 into main Oct 24, 2023
@radical
radical deleted the darc-main-760105b2-2776-43d2-ad4f-a45fc59f5f30 branch October 24, 2023 23:22
liveans pushed a commit to liveans/dotnet-runtime that referenced this pull request Nov 9, 2023
* Update dependencies from https://github.com/dotnet/installer build 20231024.2

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-alpha.1.23522.3 -> To Version 9.0.100-alpha.1.23524.2

* Suppress trim warnings

`[] /root/helix/work/workitem/e/wbt/AppSettingsTests_haqswfqc_rzt/LazyLoadingTest.cs(15,9): Trim analysis error IL2026: LazyLoadingTest.Run(): Using member 'System.Text.Json.JsonSerializer.Serialize<TValue>(TValue, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [/root/helix/work/workitem/e/wbt/AppSettingsTests_haqswfqc_rzt/WasmBasicTestApp.csproj]`

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant