Skip to content

Change Not IsWindows condition to IsLinux on Socket test disable#94163

Merged
liveans merged 3 commits into
dotnet:mainfrom
liveans:fix-socket-test-disable
Oct 31, 2023
Merged

Change Not IsWindows condition to IsLinux on Socket test disable#94163
liveans merged 3 commits into
dotnet:mainfrom
liveans:fix-socket-test-disable

Conversation

@liveans

@liveans liveans commented Oct 30, 2023

Copy link
Copy Markdown
Member

Addressing this comment

@liveans liveans requested a review from a team October 30, 2023 10:05
@liveans liveans self-assigned this Oct 30, 2023
@ghost

ghost commented Oct 30, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Addressing this comment

Author: liveans
Assignees: liveans
Labels:

area-System.Net.Sockets

Milestone: -

@MihaZupan

Copy link
Copy Markdown
Member

Can you please match this condition on the EventSource_SocketConnectFailure_LogsConnectFailed test as well (assuming it's the same underlying issue)?

@liveans

liveans commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@liveans

liveans commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@liveans

liveans commented Oct 31, 2023

Copy link
Copy Markdown
Member Author

Outerloop failure is unrelated.

@liveans liveans merged commit f2e4ddf into dotnet:main Oct 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2023
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants