Skip to content

Fix mismatch between boxed/unboxed method entrypoints#99443

Merged
MichalStrehovsky merged 3 commits into
dotnet:mainfrom
MichalStrehovsky:fix99198
Apr 22, 2024
Merged

Fix mismatch between boxed/unboxed method entrypoints#99443
MichalStrehovsky merged 3 commits into
dotnet:mainfrom
MichalStrehovsky:fix99198

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

Fixes #99198.

@MichalStrehovsky

Copy link
Copy Markdown
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@filipnavara

Copy link
Copy Markdown
Member

Are there any more places that still use MethodFlags.FunctionPointerIsUSG?

@MichalStrehovsky

Copy link
Copy Markdown
Member Author

Are there any more places that still use MethodFlags.FunctionPointerIsUSG?

The AOT compiler. I haven't started ripping out USG support from it.

@filipnavara

Copy link
Copy Markdown
Member

The AOT compiler. I haven't started ripping out USG support from it.

A quick search shows that this PR removes all the remaining uses except for the one setting the flag (and the flag definition itself).

@agocke

agocke commented Mar 23, 2024

Copy link
Copy Markdown
Member

@davidwrighton When you get a chance could you take a look at this and see if this seems like the right fix for the problem?

Comment thread src/tests/nativeaot/SmokeTests/UnitTests/Generics.cs
@MichalStrehovsky MichalStrehovsky marked this pull request as ready for review April 19, 2024 08:09
@MichalStrehovsky MichalStrehovsky merged commit 4810ba1 into dotnet:main Apr 22, 2024
@MichalStrehovsky MichalStrehovsky deleted the fix99198 branch April 22, 2024 06:34
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native AOT bad code gen for constrained call

4 participants