Skip to content

Add support for connection_pool >= 3.0#163

Merged
tenderlove merged 2 commits into
drbrain:masterfrom
jukra:connection_pool_3
Dec 30, 2025
Merged

Add support for connection_pool >= 3.0#163
tenderlove merged 2 commits into
drbrain:masterfrom
jukra:connection_pool_3

Conversation

@jukra

@jukra jukra commented Dec 8, 2025

Copy link
Copy Markdown
Contributor
stack.push connection_args: popped

So I added the connection_args with another value for clear separation of obj and options (https://github.com/mperham/connection_pool/blob/v3.0.2/lib/connection_pool/timed_stack.rb#L38)

stack.push popped, connection_args: 'default'

to make the tests more clear.

@jukra jukra force-pushed the connection_pool_3 branch from af23b93 to 27e8f12 Compare December 8, 2025 18:39
@mscrivo

mscrivo commented Dec 19, 2025

Copy link
Copy Markdown

Should someone be tagged to take a look at this? Probably blocking a lot of folks from upgrading sidekiq

@jukra

jukra commented Dec 29, 2025

Copy link
Copy Markdown
Contributor Author

@tenderlove when you have a second, could you take a look at this?

@tenderlove

Copy link
Copy Markdown
Collaborator

Ooof. Thanks for being persistent (lol). It looks good, I'll merge and release after CI returns.

@PikachuEXE

Copy link
Copy Markdown

I think we should also update ubuntu version since 20.04 is removed
https://github.blog/changelog/2025-02-12-notice-of-upcoming-deprecations-and-breaking-changes-for-github-actions/

@tenderlove

Copy link
Copy Markdown
Collaborator

I think we should also update ubuntu version since 20.04 is removed

I sent a PR to modernize CI. Unfortunately it seems like we have some legit failures on modern Ruby #165

I'll try to get it fixed and then ship all of these.

@tenderlove tenderlove merged commit 260647b into drbrain:master Dec 30, 2025
9 checks passed
@tenderlove

Copy link
Copy Markdown
Collaborator

This should be shipped now as v4.0.7. I've also switched the release process to use trusted publishing. If there's any problems, please let me know and I'll ship a new version!

@slbug

slbug commented Dec 30, 2025

Copy link
Copy Markdown

@tenderlove thank you, works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants