You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're having some nasty thing I don't know yet that is making the tests fail. I want to fix it before accepting this. About the order, there's an utility in Utilities.js created recently that we have to change everything in the lib that uses order to pass it through this utility.
I found the bug, it was sqlite3 v2.1.10. I had to downgrade to v2.1.7.
Although this pull now passes, I'm going to refuse it and change the .order() to accept any number of arguments and use Utilities.standardizeOrder. Thank you pointing this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Model.find()you can order by multiple columns, this was not possible in aggregates