Use Self type from PEP 673 - #327
Merged
Merged
Conversation
Contributor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
========================================
- Coverage 94.5% 94.3% -0.2%
========================================
Files 22 22
Lines 1463 1466 +3
========================================
Hits 1383 1383
- Misses 80 83 +3
|
pjbull
approved these changes
Apr 16, 2023
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the custom type variable
DerivedCloudPathwith the special typeSelfadded in Python 3.11 (addstyping_extensionsbackport dependency for older Python versions). This works in a functionally identical way as what we had before, as explained in the official docs, but is a part of the standard library and much more readable.For more context, see PEP 673.