Repository navigation
Add Onyx mainnet and testnet - #284
Conversation
tonatoz
left a comment
There was a problem hiding this comment.
Thanks for the PR! The overall structure looks good: chain IDs and grpcId values don't collide with main, eth_chainId matches on both endpoints, and the regenerated common.pb.go is consistent with the proto change. A few things to address before merge:
- Testnet
expected-block-timedoesn't match the observed block time (details inline). - The testnet entry in
chains-meta.yamlpoints to the mainnet explorer (details inline). - The chain icon is missing. Could you add it to
icons/and register it inicons/getChainIcon.tsunder theonyxkey? Without it, the chain shows up in the UI without a logo.
Also, a heads-up: #289 (LUKSO) touches the same lines in chains.yaml, chains-meta.yaml, proto/common.proto and pkg/dshackle/common.pb.go, so one of the two PRs will need a rebase and a common.pb.go regeneration after the other one is merged.
| short-names: [onyx-testnet] | ||
| chain-id: 0x22c5 | ||
| settings: | ||
| expected-block-time: 2s |
There was a problem hiding this comment.
On https://rpc.testnet.goliath.net the average block time is ~3.7s right now: 3.67s over the last 1,000 blocks and 3.70s over the last 100,000 blocks. Could you update this to match the current value (e.g. 4s)? The value is used for lag and head-staleness detection, so a too-low value may cause testnet upstreams to be marked as lagging.
| decimals: 18 | ||
| chain-id: 8901 | ||
| explorers: | ||
| - https://onyxscan.org |
There was a problem hiding this comment.
This is the mainnet explorer. Is there a dedicated testnet explorer (chain ID 8901)? If so, please use its URL here. If there isn't one, it's better to leave the explorers list empty than to point to mainnet.
|
Thanks for the review; I'll rebase as @pxlvre 's PR has been merged today |
Add Onyx (native coin XCN, formerly Goliath), an EVM-compatible L1.
Chains
327(0x147),grpcId1179, RPChttps://rpc.onyx.org, explorer https://onyxscan.org8901(0x22c5),grpcId10214, RPChttps://rpc.testnet.goliath.netSettings
type: eth,validate-peers: false: the JSON-RPC relay (goliath-relay) returnsUnsupported JSON-RPC methodfornet_peerCount.expected-block-time: 1s(measured: ~1.0s per block over blocks 1,048,576 to 2,097,152 on mainnet). Testnet overridden to2s(~2.15s over the same range).eth_chainIdverified on both endpoints;eth_getBlockReceiptsis supported.baseFeePerGasis 0.Files
chains.yaml,chains-meta.yamlproto/common.protoand the regeneratedpkg/dshackle/common.pb.go(ChainRef1179 / 10214; protoc 36.1, protoc-gen-go v1.36.12, same as the existing header)Not included: icon and description,
lower-bounds.