add blockchain parameters + genesis#272
Merged
Merged
Conversation
scravy
force-pushed
the
blockchain-parameters
branch
3 times, most recently
from
bdbcdd8 to
5d2c8d3
Compare
scravy
changed the title
castarco
reviewed
Nov 21, 2018
castarco
reviewed
Nov 21, 2018
kostyantyn
reviewed
Nov 21, 2018
kostyantyn
reviewed
Nov 21, 2018
castarco
reviewed
Nov 21, 2018
kostyantyn
reviewed
Nov 21, 2018
AM5800
reviewed
Nov 21, 2018
nzmdn
reviewed
Nov 21, 2018
AM5800
reviewed
Nov 21, 2018
scravy
force-pushed
the
blockchain-parameters
branch
from
f8fbe29 to
a55df92
Compare
Member
Author
|
@AM5800 @cornelius @castarco @kostyantyn @frolosofsky @Nizametdinov please re-review, I think I tackled all your comments. |
kostyantyn
reviewed
Nov 22, 2018
Signed-off-by: Julian Fleischer <julian@thirdhash.com>
Signed-off-by: Julian Fleischer <julian@thirdhash.com>
scravy
force-pushed
the
blockchain-parameters
branch
from
a55df92 to
a1abd37
Compare
AM5800
approved these changes
Nov 22, 2018
Ruteri
reviewed
Nov 22, 2018
Member
There was a problem hiding this comment.
NIT: We will need to differentiate the parameters for networks (esp. the difficulty), but we will not be able to use the wrapper const CBlock Build(std::initializer_list<P2WPKH> outputs) then. Maybe genesis block params should be a separate structure that we also pass into the Build along with outputs?
Member
Author
|
@Ruteri as discussed over lunch, I will add that when needed later. |
This was referenced Nov 22, 2018
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am starting to separate things from #212 in order for it to be easier reviewable and mergable. This particular piece is the blockchain parameters and genesis block creation.
Ultimately I want to get rid of
chainparams(and chainparamsbase and the like). The idea here being that it can't even conflict with bitcoin if it does not exist. Since we're starting over we are not interested in bitcoin checkpoints, bitcoin versions, etc. Also this version is way cleaner.Right now it would be dead code though, which changes once merged with #212. I nevertheless would like to merge this separately.
Signed-off-by: Julian Fleischer julian@thirdhash.com