Skip to content

Add RPC call for remote staking one or more coins#541

Merged
cmihai merged 19 commits into
dtr-org:masterfrom
cmihai:stakeat-rpc
Feb 8, 2019
Merged

Add RPC call for remote staking one or more coins#541
cmihai merged 19 commits into
dtr-org:masterfrom
cmihai:stakeat-rpc

Conversation

@cmihai

@cmihai cmihai commented Feb 4, 2019

Copy link
Copy Markdown
Member

The new RPC call is similar to sendtypeto, except only one output is allowed, and the user cannot provide a custom redeem script.

The remotely staked outputs do not currently show in listunspent, so this PR is contingent on #517.

The new RPC call is similar to `sendtypeto`, except only one output is
allowed, and the user cannot provide a custom redeem script.

Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
@cmihai cmihai added wallet wip Work in progress which is not supposed to be merged yet labels Feb 4, 2019
@cmihai cmihai requested a review from nzmdn February 4, 2019 13:39
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Comment thread src/wallet/rpcwalletext.cpp Outdated
Comment thread src/esperanza/walletextension.cpp Outdated
Comment thread src/esperanza/walletextension.cpp Outdated
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Comment thread test/functional/feature_remote_staking.py Outdated
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Comment thread test/functional/feature_remote_staking.py Outdated
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
@cmihai cmihai removed the wip Work in progress which is not supposed to be merged yet label Feb 4, 2019
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
@cmihai cmihai requested a review from a team February 6, 2019 15:30
Comment thread src/wallet/rpcwalletext.cpp Outdated
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Comment thread src/wallet/rpcwalletext.cpp Outdated
Comment thread test/functional/feature_remote_staking.py Outdated
Comment thread test/functional/feature_remote_staking.py Outdated
Comment thread src/esperanza/walletextension.cpp Outdated
Comment thread src/esperanza/walletextension.cpp Outdated
Comment thread src/wallet/rpcwalletext.cpp Outdated
Comment thread src/wallet/rpcwalletext.cpp Outdated
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>

@nzmdn nzmdn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4d10581

Comment thread test/functional/feature_remote_staking.py Outdated

@Ruteri Ruteri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2f696fd

@cmihai cmihai merged commit 1aa891f into dtr-org:master Feb 8, 2019
@cmihai cmihai deleted the stakeat-rpc branch February 8, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants