Add tests for ContextualCheckBlock#579
Merged
Merged
Conversation
added 2 commits
February 11, 2019 16:37
Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>
Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>
castarco
reviewed
Feb 11, 2019
scravy
approved these changes
Feb 11, 2019
castarco
reviewed
Feb 11, 2019
castarco
reviewed
Feb 11, 2019
scravy
approved these changes
Feb 11, 2019
castarco
approved these changes
Feb 11, 2019
added 2 commits
February 11, 2019 16:56
Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>
Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>
Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>
castarco
reviewed
Feb 11, 2019
castarco
previously requested changes
Feb 11, 2019
castarco
left a comment
castarco
left a comment
There was a problem hiding this comment.
A couple of tests have to be fixed.
Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>
castarco
reviewed
Feb 12, 2019
This was referenced Feb 13, 2019
scravy
added a commit
that referenced
this pull request
Feb 13, 2019
- Removes one PoW check in ::ContextualCheckBlockHeader - Remove bad-diffbits check from feature-block tests This uses `BlockValidator::ContextualCheckBlockHeader` as a drop-in replacement in `ContextualCheckBlockHeader`. Thanks to the tests which were added by @Gnappuraz in #579 the very same tests will also check the new contextual check block. This does remove one PoW check. All other PoW checks are still there, especially in `CheckBlockHeader`. The new `BlockValidator::ContextualCheckBlockHeader` does invoke `BlockValidator::CheckBlockHeader` if the validation context passed in `ValidationInfo` does not know that it succeeded already. The new `BlockValidator::CheckBlockHeader` does not do a `PoW` check but it checks that the timestamp is well-formed. This check is bypassed and there's UNIT-E TODO slapped on to it. Disabling the check for `bad-diffbits`. This is the check which was actually removed, it is in contextual check block to check the difficulty against the calulated one. This works completely different in the PoS setting as it affects the kernel protocol. Signed-off-by: Julian Fleischer <julian@thirdhash.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit test coverage for ContextualCheckBlock(). This helps #553.