Check block reward maturity instead of block maturity by Gnappuraz · Pull Request #714 · dtr-org/unit-e

Gnappuraz · 2019-03-01T16:45:09Z

In preparation to PoS we change how some checks are performed in the wallet to determine the maturity of some balance. Before this PR the whole coinbase is considered either mature or not for accounting purposes, this PR differentiates the maturity of the first output of the coinbase from the others (at the moment there is none except the commitment that has value = 0 anyway).

This PR should be merged after #709 since it cointains some of its code.

cmihai · 2019-03-01T17:18:23Z

this PR differentiates the maturity of the first output of the coinbase from the others (at the moment there is none except the commitment that has value = 0 anyway).

How does this interact with the stake_split_threshold? If the user is staking a coin worth over 5000 UTE, he'll get several outputs: one immature and the rest mature. Is this what we want?

thothd · 2019-03-01T17:29:04Z

this PR differentiates the maturity of the first output of the coinbase from the others (at the moment there is none except the commitment that has value = 0 anyway).

How does this interact with the stake_split_threshold? If the user is staking a coin worth over 5000 UTE, he'll get several outputs: one immature and the rest mature. Is this what we want?

It's gonna change later when implementing the rewards pool (already started) for now we can treat it as keeping the reward functionality which is also relevant for Unit-e and adding another output for PoS (the stake).
Sounds like it's complementary to stake_split_threshold and it's anyway just doing it for the immediate reward which again gonna be very small when implementing the rewards pool in #504

Gnappuraz · 2019-03-01T17:52:51Z

+CAmount CWalletTx::GetImmatureCredit() const
 {
-    if (IsCoinBase() && GetBlocksToMaturity() > 0 && IsInMainChain()) {
-        if (fUseCache && fImmatureCreditCached) {


I'm removing the cache cause it is only used by rpc and it would be way more tricky to invalidate the cache for coinbases without every time checking if the maturity of the reward output changed.

scravy · 2019-03-03T14:23:32Z

@Gnappuraz I took the liberty and rebased this to get the fix from #715 and make the tests pass.

Gnappuraz · 2019-03-03T16:51:57Z

@scravy thx

Ruteri

utACK 1c6c501

kostyantyn

utACK 9083694

AM5800

ACK 9083694
Compiled and debugged unit-test

However would like few nits to be addressed

scravy

Concept ACK 9083694

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Signed-off-by: Mateusz Morusiewicz <mateusz@thirdhash.com>

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Signed-off-by: Julian Fleischer <julian@thirdhash.com>

scravy · 2019-03-05T20:02:07Z

Rebased.

Gnappuraz requested review from a team and scravy March 1, 2019 16:45

Gnappuraz added the feature New functionality label Mar 1, 2019

Gnappuraz self-assigned this Mar 1, 2019

cmihai reviewed Mar 1, 2019

View reviewed changes

Comment thread src/wallet/wallet.cpp Outdated

cmihai reviewed Mar 1, 2019

View reviewed changes

Comment thread src/wallet/wallet.cpp Outdated

cmihai reviewed Mar 1, 2019

View reviewed changes

Comment thread src/wallet/wallet.cpp Outdated

Ruteri reviewed Mar 1, 2019

View reviewed changes

Comment thread src/wallet/wallet.cpp Outdated

Comment thread src/wallet/wallet.cpp Outdated

Comment thread src/wallet/wallet.cpp Outdated

Gnappuraz commented Mar 1, 2019

View reviewed changes

Ruteri approved these changes Mar 4, 2019

View reviewed changes

kostyantyn reviewed Mar 4, 2019

View reviewed changes

Comment thread src/wallet/test/wallet_tests.cpp

kostyantyn reviewed Mar 4, 2019

View reviewed changes

Comment thread src/wallet/wallet.cpp Outdated

kostyantyn reviewed Mar 4, 2019

View reviewed changes

Comment thread src/wallet/wallet.cpp Outdated

kostyantyn approved these changes Mar 5, 2019

View reviewed changes

AM5800 reviewed Mar 5, 2019

View reviewed changes

Comment thread src/wallet/wallet.cpp Outdated

AM5800 reviewed Mar 5, 2019

View reviewed changes

Comment thread src/wallet/wallet.cpp Outdated

AM5800 reviewed Mar 5, 2019

View reviewed changes

Comment thread src/wallet/test/wallet_tests.cpp Outdated

AM5800 approved these changes Mar 5, 2019

View reviewed changes

scravy approved these changes Mar 5, 2019

View reviewed changes

Matteo Sumberaz added 7 commits March 5, 2019 21:01

Add GetBlocksToMaturities()

719bb1b

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Add more tests to the wallet

e04bcca

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Refactor GetCredit

407abac

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Change var name

d47857e

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Add MatureCredit and ImmatureCredit functions

ffcc26c

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Make GetCredit use GetMatureCredit

961e8bf

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Fix test

902cd63

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Matteo Sumberaz and others added 11 commits March 5, 2019 21:01

Fix nits

1493679

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Use RewardMaturity 4 ImmatureCredit & AvailBalance

a6bae82

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Check reward maturity

ab2902d

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Remove cache

d15e730

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Rework loop

cf3bb9a

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Fix after rebase

0e970f6

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Remove unused cache flags

f98ece3

Signed-off-by: Mateusz Morusiewicz <mateusz@thirdhash.com>

Properly cache coinbase

0c157b7

Signed-off-by: Mateusz Morusiewicz <mateusz@thirdhash.com>

Fix some nits

be68809

Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>

Use manifest typing instead of auto, make const

b035c77

Signed-off-by: Julian Fleischer <julian@thirdhash.com>

Fix nits

0a7fa7d

Signed-off-by: Julian Fleischer <julian@thirdhash.com>

scravy merged commit 0f2efa7 into dtr-org:master Mar 5, 2019

scravy deleted the getblocktomaturity-per-vout branch March 5, 2019 20:20

This was referenced Mar 6, 2019

Disable transaction_tests/tx_valid by other means than boost::disabled() #740

Merged

User bigger coins first to stake is not rational for the proposer #762

Closed

scravy mentioned this pull request Mar 13, 2019

Implement stake maturity #785

Closed

Uh oh!

Conversation

Gnappuraz commented Mar 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmihai commented Mar 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thothd commented Mar 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gnappuraz Mar 1, 2019

Choose a reason for hiding this comment

Uh oh!

scravy commented Mar 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gnappuraz commented Mar 3, 2019

Uh oh!

Ruteri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kostyantyn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AM5800 left a comment

Choose a reason for hiding this comment

Uh oh!

scravy left a comment

Choose a reason for hiding this comment

Uh oh!

scravy commented Mar 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Gnappuraz commented Mar 1, 2019 •

edited

Loading

cmihai commented Mar 1, 2019 •

edited

Loading

thothd commented Mar 1, 2019 •

edited

Loading

scravy commented Mar 3, 2019 •

edited

Loading