Skip to content

Run service-dialog adapter regression tests in CI #70

Description

@rmcdaniel

Problem

Commit df2e3386c19237ba484b2c2a988c2d83e1f657ab adds tests/Node/ServiceModeDialogVisualTest.mjs to protect the service-mode Waterline adapter’s stable-open wait, rejected-geometry retention, and fail-closed handling of an unsupported installed audit. No package script or GitHub Actions step invokes the Node test suite. The end-to-end service-mode smoke proves the current all-passing dialog matrix, but it does not exercise the failed-geometry path, so the diagnostic regression can return without failing CI until another responsive defect occurs.

Acceptance criteria

  • Run the service-dialog Node regression test on pull requests and pushes to main after the installed Waterline package is available.
  • Keep the test fail-closed when the installed audit source no longer matches the supported adapter contract.
  • Prove the executed test covers the stable-open wait and retains measured geometry before rejecting a failed geometry audit.
  • Preserve the existing fresh-and-repeat eight-case browser qualification.

Delete when

Delete this item when protected-branch CI visibly executes the Node regression test and fails if either stable-layout waiting or failed-geometry retention is removed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    authority:githubGitHub is the authoritative lifecycle record for this workbeta:compatibleMay be completed without changing the frozen beta contractkind:defectA public product behavior is incorrectpriority:P2Normal-priority product workrepo:sample-appOwned by the sample application repositorystatus:doneDerived from the authoritative closed issue state

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions