Restart profile queue worker after backend loss - #274
Merged
Merged
Conversation
2 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Match the published Server Compose queue-worker restart policy in the disposable standard-workflow performance profile. The profile is used by Server #137 runtime comparison and backend-interruption checks. The production Compose stack already uses
restart: unless-stoppedfor its queue worker.Why
In a local exact-image Swoole qualification fixture, stopping Redis caused the profile's queue worker to exit with a connection error. Server readiness correctly returned 503 and recovered when Redis returned, but workflow processing did not resume until the queue worker was started manually. This was a fixture configuration gap, not an HTTP runtime change.
Verification
docker compose ... config --format jsonreportsservices.worker.restart = unless-stopped.WorkflowCompletedhistory entries across the earlier interruption and follow-up probes. Server and worker had zero OOM kills.This adjusts only the disposable profile. It does not select or publish Swoole.
The repository-contract CI run also exposed a binary-read bug in the regression-corpus validator:
git showof a tracked gzip blob was decoded as UTF-8 before being re-encoded. The validator now reads Git blob bytes directly. A Python 3.12 container run against base10b367a835661e2c621249dc4842fd18ef7ab2e4passed the full regression-corpus validation with unchanged 16/16 codec cases and no review-required paths.Part of #137.