Minor TODO formatting and a doctest fix - #78
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 31 31
Lines 5317 5317
=======================================
Hits 4795 4795
Misses 522 522 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| def sydg(qubit: QCDLModule) -> None: | ||
| r"""SQRT of Y_adjoint gate. | ||
| TODO it's not a qiskit gate | ||
| .. todo:: it's not a qiskit gate (comment from @qci-amos) |
There was a problem hiding this comment.
what todo do you have in mind?
There was a problem hiding this comment.
@qci-amos, wasn't this your comment originally? I just made it visible.
Or maybe when I was linking to the corresponding Quskit gates I couldn't find this one
qci-amos
left a comment
qci-amos
left a comment
There was a problem hiding this comment.
ok, let's just remove those lines then
Sure, this is originally your comment |
Apply suggestion from @qci-amos Co-authored-by: Amos Anderson <45039789+qci-amos@users.noreply.github.com>
| .. testcode:: | ||
| :hide: | ||
|
|
||
| print(print_qcdl(qcdl_program)) |
There was a problem hiding this comment.
The second print shouldn't be needed, right?
| print(print_qcdl(qcdl_program)) | |
| print_qcdl(qcdl_program) |
There was a problem hiding this comment.
It's a quirk of doctest: it outputs content of a print() statement that can be tested but without that print() statement the code in line 74 does not produce output. This is why I added the hidden testcode directive of line 78, to produce output that is tested by the testoutput directive in line 83
3 participants
Planned to do more on this one but running out of time, so at least have the TODOs visible for reviewers