Skip to content

Update ValidatingTrait.php - #114

Merged
dwightwatson merged 1 commit into
dwightwatson:0.10from
Shingedo:0.10
Dec 10, 2014
Merged

dwightwatson merged 1 commit into
dwightwatson:0.10from
Shingedo:0.10

Conversation

@Shingedo

Copy link
Copy Markdown

Fixed unique validation rule detection to only detect the unique: rule and not other similar named rules like unique_with:

Fixed unique validation rule detection to only detect the `unique:` rule and not other similar named rules like `unique_with:`
dwightwatson added a commit that referenced this pull request Dec 10, 2014
Update ValidatingTrait.php
@dwightwatson
dwightwatson merged commit df6a8bf into dwightwatson:0.10 Dec 10, 2014
dwightwatson added a commit that referenced this pull request Dec 10, 2014
@dwightwatson

Copy link
Copy Markdown
Owner

Cheers. I suppose unique_with: is provided by some third-party package because it doesn't come with Laravel. Either way it makes sense to lock it down here.

@Shingedo

Copy link
Copy Markdown
Author

Yeah it is a custom rule, but the name isnt really relevant because without this fix it will falsely detect any rule of format unique(.*):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants