[holmboe]

Lock file maintenance (#534) moves typer from 0.25.1 to 0.27.2 and fails 71 tests. Swapping one package at a time shows typer alone is the cause: click 8.5 with typer 0.25.1 passes everything.

From 0.26, typer builds on its own copy of click, typer._click, so anything phabfive or its tests take from the click package no longer matches what typer hands back.

A real bug: create --with (e0a2f67)

options_given in phabfive/cli/create_spec.py compared the parameter source against click.core.ParameterSource.DEFAULT. typer's context returns its own enum, so the identity check never matched, every option counted as given, and maniphest create --with refused every spec. pyproject.toml allows typer>=0.12.0, so anyone who installs from PyPI today gets typer 0.27 and hits this. The check now compares by name, which works on both.

The tests (7ed1a3f)

The completion tests used click's completion registry, which typer no longer fills, and click's ShellComplete. typer's copy of ShellComplete is abstract. The comment-editor tests patched the stdin wrapper in click.testing, which typer's CliRunner no longer uses. tests/click_layer.py picks whichever click typer is using. The two spec-file completer tests now take their context from the real command, so they don't need the helper.

Verified

• uv run pytest with the current lock (typer 0.25.1, click 8.3.1): 5971 passed
• the same with chore(deps): lock file maintenance #534's uv.lock (typer 0.27.2, click 8.5.0): 5971 passed
• ruff and mypy are clean

When this merges, Renovate should rebase #534 and it should go green.

Fixes #330

🤖 Generated with Claude Code

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Adapts CLI tests and code to support typer 0.26 with bundled click.

This PR appears safe to merge; no actionable issues were found.

What we checked:

• Spec completion still checks files: complete_spec_file takes only the incomplete path. Both tests still call the real option and check exact file and directory names.

Summary

This PR fixes options_given for Typer versions that carry their own Click copy.

• It compares parameter sources by name instead of comparing enum objects from different packages.
• Completion tests select Typer's completion classes and use contexts from real commands.
• Comment-editor tests patch the stdin wrapper used by Typer's runner.
• No actionable issues were found. Tests were not run during this review.

_{Reviews (1) · Last reviewed commit: "test: drive completion through the click..." · Reviewed by Greptile}