Repository navigation
fix: include dotfiles in template file uploads - #1162
Merged
Merged
Conversation
Enable glob patterns to match files starting with dot (e.g., .env, .gitignore). The glob library defaults to dot: false in JS and wcmatch.glob requires DOTMATCH flag in Python, which excluded dotfiles from uploads. - JS SDK: add dot: true to glob calls in getAllFilesInPath - Python SDK: add glob.DOTMATCH flag to glob calls in get_all_files_in_path - Add comprehensive tests for dotfile handling in both SDKs Fixes issue where dotfiles could not be uploaded with templates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: fc3cbcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Package ArtifactsBuilt from 213fdcd. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.13.1-mishushakov-fix-dotfile-upload.0.tgzCLI ( npm install ./e2b-cli-2.7.2-mishushakov-fix-dotfile-upload.0.tgzPython SDK ( pip install ./e2b-2.14.0+mishushakov.fix.dotfile.upload-py3-none-any.whl |
mishushakov
enabled auto-merge (squash)
February 25, 2026 12:35
djeebus
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.env,.gitignore)dot: trueto glob calls ingetAllFilesInPathglob.DOTMATCHflag to glob calls inget_all_files_in_pathPreviously, the glob library defaults prevented dotfiles from being matched, preventing upload of configuration files like
.env. This fix enables proper handling of dotfiles in template file uploads.Test plan
pnpm run formatpassespnpm run lintpassespnpm run typecheckpasses🤖 Generated with Claude Code
Note
Low Risk
Small, well-scoped change to glob options that only broadens matched file sets; main risk is unintentionally including hidden files unless excluded via ignore patterns.
Overview
Template file collection now includes dot-prefixed files and directories (e.g.,
.env,.gitignore,.hidden/**) when building/uploading templates.This updates globbing in the JS SDK’s
getAllFilesInPathto setdot: true(including recursive directory expansion) and the Python SDK’sget_all_files_in_pathto addglob.DOTMATCH, and adds targeted tests in both SDKs to verify dotfile inclusion and that ignore patterns still exclude specified dotfiles. A changeset bumps bothe2band@e2b/python-sdkas patch releases.Written by Cursor Bugbot for commit fc3cbcc. This will update automatically on new commits. Configure here.