Sampler engine structure #280 - #287
Open
rozyczko wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core refactoring and shared logic:
EngineBase(engine_base.py) as a new base class for all evaluation engines (minimizers and samplers), with centralized parameter handling, fit function wrapping, and evaluation logic.MinimizerBaseso it inherits fromEngineBase. Cleaned up the constructor and removed duplicated parameter caching logic.Bumps integration and utilities:
bumps_utils/problem.py, includingbuild_curve_problem,to_bumps_parameter,parameter_names, andparameter_snapshot. These are now imported and exposed inbumps_utils/__init__.py.bumps_utils/validation.py) with functions for validating run settings and input arraysAPI changes and deprecations:
mcmc_sample()now lives onSamplerclass directly. The method now routes calls toSampler(...).sample(...)progress_callbacksignature inMinimizerBase.fitto clarify that its return value is ignored and to align with the new shared engine base.