🎉 Release: merge develop into master - #236
Merged
Merged
Conversation
![easyscience[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
* Fix units of model_base * pixi update and pixi run fix and revert contributing.md change * Propagate units through unit-unaware collection and model-array construction - ModelBase._convert_axis_unit: convert the template collection as a whole so its own unit attribute updates; regenerated per-Q collections then carry the converted unit instead of the stale default. - Analysis1d._to_scipp_array / Analysis._create_model_array: stamp the sample model y_unit on model arrays. Previously they were always dimensionless, so residuals and plots failed with a UnitError whenever the data had a real unit (e.g. counts), regardless of the models units. - Analysis1d._build_convolution: pass the sample model units to Convolution. - Convolution plan and ModelComponent wrapping: internal ComponentCollections now inherit units instead of silently defaulting to meV/dimensionless. Add regression tests for all of the above. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
sc.bin cannot handle multi-dimensional dense data with bin-edge coordinates, so convert them to bin centers before binning. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
easyscience
Bot
added
the
[bot] release
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 98.99% 99.01% +0.02%
==========================================
Files 53 53
Lines 4060 4060
Branches 706 706
==========================================
+ Hits 4019 4020 +1
Misses 19 19
+ Partials 22 21 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created automatically to trigger the release pipeline. It merges the accumulated changes from
developintomaster.[bot] releaseand is excluded from release notes and version bump logic.