Repository navigation
Conversation
divarvel
reviewed
Oct 29, 2026
| @@ -0,0 +1,28 @@ | |||
| package org.eclipse.biscuit.datalog; | |||
|
|
|||
| public class StepCounter implements Cloneable { | |||
Contributor
There was a problem hiding this comment.
note: World is Serializable. I think it comes from the initial iteration and hopefully nothing relies on this.
@Korbik i’d be in favor of dropping Serializable everywhere, but if we can’t, then we should make StepCounter serializable
saoirse-a
force-pushed
the
saoirse/max-steps
branch
from
November 3, 2026 14:15
dea64c8 to
e845a9b
Compare
Adds a maxSteps limit to the RunLimits in protobuf. Uses a StepCounter owned by World that is incremented during rule evaluation (for each fact and each operation) and queries. Signed-off-by: Saoirse Aronson <saoirse@apple.com> Co-authored-by: Sasha Kobrusev <skobrusev@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a maxSteps limit to the RunLimits in protobuf. Uses a StepCounter owned by World that is incremented during rule evaluation (for each fact and each operation) and queries.
Comparable to eclipse-biscuit/biscuit-rust#352