Conversation
crimson11
force-pushed
the
tutorial
branch
5 times, most recently
from
c057b8e to
a18e3c2
Compare
crimson11
requested review from
LittleHuba,
bemerybmw,
castler,
hoe-jo and
limdor
as code owners
| @@ -0,0 +1,91 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |
| * Copyright (c) 2026 Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
Fixed all Copyright dates.
| g_running.store(false, std::memory_order_relaxed); | ||
| } | ||
|
|
||
| using HelloWorldProxy = score::mw::com::AsProxy<score::mw::com::tutorial::HelloWorldInterface>; |
There was a problem hiding this comment.
how about keeping this into score/mw/com/doc/tutorial/chapter_1/hello_world_service.h
There was a problem hiding this comment.
Let me merge this 1st - later we can change this. Right now I need this urgently merged as some people are already providing PRs with examples, where I feel this can be potentially redundant! This has to be avoided at all costs!
| > This you could find out by looking into the implementation of the `AsSkeleton` template in | ||
| > [traits.h](../../../impl/traits.h) and following the inheritance chain of the generated skeleton class. | ||
|
|
||
| Then in line 40 we create an instance of the skeleton class with the `Create` (named constructor) method: |
There was a problem hiding this comment.
I think adding line number will add additional maintenance effort.
There was a problem hiding this comment.
Yes. Maybe. But the tutorial should bestable soonish. And then having exact line numbers is very helpful.
| } | ||
| } | ||
|
|
||
| auto proxy_result = HelloWorldProxy::Create(service_handle.value()); |
There was a problem hiding this comment.
| auto proxy_result = HelloWorldProxy::Create(service_handle.value()); | |
| // create proxy ..... | |
| auto proxy_result = HelloWorldProxy::Create(service_handle.value()); |
I appreciate the detailed README you created. However, adding comments within the code would make it much easier for new users to understand the logic and flow of the implementation.
There was a problem hiding this comment.
See above. CAn be done later if needed.
| @@ -0,0 +1,18 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |
| * Copyright (c) 2026 Contributors to the Eclipse Foundation |
| @@ -0,0 +1,13 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |
| * Copyright (c) 2026 Contributors to the Eclipse Foundation |
| @@ -0,0 +1,31 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |
| * Copyright (c) 2026 Contributors to the Eclipse Foundation |
crimson11
force-pushed
the
tutorial
branch
6 times, most recently
from
5f6381d to
160cddd
Compare
Created a tutorial containing working code for currently supported score::mw::com feature set of the C++ binding.
2 participants
Created a tutorial containing working
code for currently supported score::mw::com
feature set of the C++ binding.