mw::com: Update slot count based on the presence of Notifer Tag in Field.#650
Open
KrishaDeshkool wants to merge 9 commits into
Open
mw::com: Update slot count based on the presence of Notifer Tag in Field.#650KrishaDeshkool wants to merge 9 commits into
KrishaDeshkool wants to merge 9 commits into
Conversation
KrishaDeshkool
force-pushed
the
update_slot_count
branch
15 times, most recently
from
b706d9d to
3701ecf
Compare
KrishaDeshkool
force-pushed
the
update_slot_count
branch
11 times, most recently
from
6557421 to
91b502b
Compare
KrishaDeshkool
requested review from
LittleHuba,
bemerybmw,
crimson11,
hoe-jo and
limdor
as code owners
A field without a notifier passes a fixed slot count override here. The tracing slots (a std::uint8_t) are added on top the override is small number(2) so the sum cannot overflow, no extra check needed.
The field passes its notifier capability to the binding factory, which uses it to pick the slot count for the field's backing event.
CreateSkeletonEventOrField is now CreateSkeletonServiceElement, a shared helper behind two typed entry points: CreateSkeletonEvent (no slot count override) and CreateSkeletonField (with one). The event factory no longer sees a field-only parameter.
KrishaDeshkool
force-pushed
the
update_slot_count
branch
from
91b502b to
f5d0a99
Compare
KrishaDeshkool
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the slot counts based on this matrix
WithNotifier(enabled) && numberOfSampleSlots(configured) -> use configured sample slots
WithNotifier(enabled) && numberOfSampleSlots(missing) -> none, startup terminates
WithNotifier(disabled) && numberOfSampleSlots(missing) -> 2
WithNotifier(disabled) && numberOfSampleSlots(configured) -> 2 + a warning is logged