Rust::com Rust interface macro syntax fix #682
Merged
castler merged 3 commits intoJul 10, 2026
Merged
Conversation
* Removed the comma on custom id pattern
* Update the example app for updated interface macro
bharatGoswami8
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
* Interface macro changes adapted
bharatGoswami8
force-pushed
the
rust_interface_macro_update
branch
from
5520720 to
2472cff
Compare
rpreddyhv
reviewed
Jul 9, 2026
| $crate::interface_producer!($id, $($event_name, Event<$event_type>),+); | ||
| }; | ||
|
|
||
| // This is for backward compatibility for existing users with comma (,) |
There was a problem hiding this comment.
question: do we know if there existing users who are using this? When do we plan to eliminate this?
Contributor
Author
There was a problem hiding this comment.
Yes, as i know FEO is using, any other is using that i am not sure.
We will announce in COM CFT about this changes.
darkwisebear
approved these changes
Jul 10, 2026
darkwisebear
left a comment
darkwisebear
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much, it was hurting my eyes :)
castler
approved these changes
Jul 10, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#681