Fixing left over fd on child processes - #289
Merged
NicolasFussberger merged 7 commits intoJul 13, 2026
Merged
Conversation
MaciejKaszynski
requested a deployment
to
workflow-approval
July 7, 2026 07:33 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 7, 2026 07:33 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
MaciejKaszynski
force-pushed
the
fix-leaked-fd
branch
from
July 7, 2026 10:45
5d42deb to
580e0c6
Compare
MaciejKaszynski
requested a deployment
to
workflow-approval
July 7, 2026 10:45 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 7, 2026 10:45 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 9, 2026 09:57 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 9, 2026 09:57 — with
GitHub Actions
Waiting
SimonKozik
reviewed
Jul 10, 2026
MaciejKaszynski
requested a deployment
to
workflow-approval
July 10, 2026 10:59 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 10, 2026 10:59 — with
GitHub Actions
Waiting
MaciejKaszynski
temporarily deployed
to
workflow-approval
July 10, 2026 15:17 — with
GitHub Actions
Inactive
MaciejKaszynski
temporarily deployed
to
workflow-approval
July 10, 2026 15:17 — with
GitHub Actions
Inactive
Contributor
|
Looks like some of the tests are failing in the pipeline https://github.com/eclipse-score/lifecycle/actions/runs/29103108047/job/86396720862?pr=289 |
NicolasFussberger
requested changes
Jul 13, 2026
MaciejKaszynski
force-pushed
the
fix-leaked-fd
branch
from
July 13, 2026 06:52
41dbc77 to
c9ba5d2
Compare
MaciejKaszynski
requested a deployment
to
workflow-approval
July 13, 2026 06:52 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 13, 2026 06:52 — with
GitHub Actions
Waiting
MaciejKaszynski
force-pushed
the
fix-leaked-fd
branch
from
July 13, 2026 06:56
c9ba5d2 to
d9d910c
Compare
MaciejKaszynski
requested a deployment
to
workflow-approval
July 13, 2026 06:56 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 13, 2026 06:56 — with
GitHub Actions
Waiting
NicolasFussberger
temporarily deployed
to
workflow-approval
July 13, 2026 08:17 — with
GitHub Actions
Inactive
NicolasFussberger
temporarily deployed
to
workflow-approval
July 13, 2026 08:17 — with
GitHub Actions
Inactive
NicolasFussberger
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that a child process might inherit a file descriptor, the file is deleted but still not good to have it.