Add logging showcase#267
Conversation
67795eb to
5591382
Compare
ee0df41 to
5cb2f27
Compare
|
The created documentation from the pull request is available at: docu-html |
7fdfb65 to
38c3c66
Compare
Signed-off-by: Cvam7 <108720572+ShivamPatidar24@users.noreply.github.com>
| "//patches/logging:001-logging-example-visibility.patch", | ||
| "//patches/logging:002-deps-visibility.patch"], | ||
| "metadata": { | ||
| "code_root_path": "//score/mw/...", |
There was a problem hiding this comment.
Score/datarouter and other coding folders (if any) from logging cannot be skipped from code root path
| @@ -0,0 +1,13 @@ | |||
| diff --git a/MODULE.bazel b/MODULE.bazel | |||
There was a problem hiding this comment.
the patch file name and the patch (intent) does not match.
|
|
||
| # OCI / Docker image rules for integration tests | ||
| bazel_dep(name = "rules_oci", version = "2.2.7", dev_dependency = True) | ||
| -bazel_dep(name = "rules_pkg", version = "1.2.0", dev_dependency = True) |
There was a problem hiding this comment.
Instead why not load it in reference_integration directly? IS the dep not allowed in ref_integration?
There was a problem hiding this comment.
Without the patch, the build fails with a rules_pkg visibility error. Adding rules_pkg to the root MODULE.bazel results in a duplicate bazel_dep error.
| @@ -0,0 +1,27 @@ | |||
| { | |||
| "name": "Logging example", | |||
| "description": "Example for running logging with all log levels via remote and console", | |||
There was a problem hiding this comment.
| "description": "Example for running logging with all log levels via remote and console", | |
| "description": "A Logging app that demonstrates logging with mw::log with kConsole|kRemote|kFile config.", |
| @@ -0,0 +1,27 @@ | |||
| { | |||
| "name": "Logging example", | |||
There was a problem hiding this comment.
| "name": "Logging example", | |
| "name": "LoggingApp Demo", |
| @@ -0,0 +1,7 @@ | |||
| # Logging Example | |||
|
|
|||
| This example demonstrates logging with all log levels via Console Logging and Remote Logging. | |||
There was a problem hiding this comment.
| This example demonstrates logging with all log levels via Console Logging and Remote Logging. | |
| This Logging App demonstrates logging using mw::log with all log levels and configured backends (kConsole|kRemote|kFile) enabled. |
|
|
||
| This example demonstrates logging with all log levels via Console Logging and Remote Logging. | ||
|
|
||
| For remote logging details, refer to the following documentation: |
There was a problem hiding this comment.
| For remote logging details, refer to the following documentation: | |
| For remote (DLT) logging, please refer to the following documentation: |
|
|
||
|
|
||
| def test_remote_logging(datarouter_running, dlt_config): | ||
| def test_remote_logging(datarouter_running, target, dlt_config): |
There was a problem hiding this comment.
The test here verifies if datarouter logs are available in DLT. You should add another assert statement verifying if the Logging App logs end up in DLT. I would suggest adding a seperate test for this to seperate the expectations. E.g.:
# Verifies logging app logs are forwarded to DLT by capturing DLT traces
def test_logging_app_logs_forwarded_to_dlt(datarouter_running, target, dlt_config):
There was a problem hiding this comment.
https://github.com/eclipse-score/reference_integration/pull/267/changes#r3534900206
The verification should be showcased in the Test and NOT manually!
ac3e99b to
9f49a98
Compare
Co-authored-by: Raghavendra Maddikery <raghav.maddikery@gmail.com> Signed-off-by: Cvam7 <108720572+ShivamPatidar24@users.noreply.github.com>
9f49a98 to
2cb51e4
Compare
Summary
This PR adds a Logging example showcase demonstrating local and remote logging.
The example generates logs for all supported severity levels.
Related
Issue: #229
This PR Depends on : #281
Verification
DEBUG, INFO, WARN, ERROR and FATAL logs generated
Logs visible in console output
Logs visible in DLT Viewer and Chipmunk