test(binding-http): add unit tests for CORS behavior - #1486
Merged
relu91 merged 2 commits intoFeb 18, 2026
Merged
Conversation
siddharthbaleja7
requested review from
danielpeintner and
relu91
as code owners
February 16, 2026 11:33
relu91
requested changes
Feb 16, 2026
relu91
left a comment
Member
There was a problem hiding this comment.
Good job! I'd probably just extend this current list of tests with also "writing" operations, which means testing: POST requests too (and cover writable properties + actions invocations). Can you add those cases too?
danielpeintner
approved these changes
Feb 18, 2026
This was referenced Feb 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests to
binding-httpto verify CORS behavior, addressing the need for regression testing mentioned in issue #938.The new tests cover:
nosecsecurity scheme (wildcard origin).basicsecurity scheme (reflected origin + credentials), covering both authorized (200) and unauthorized (401) responses.OPTIONSpreflight requests.Motivation and Context
Currently,
http-serverimplements CORS logic but lacks specific unit tests. These tests ensure that CORS headers are correctly set for different security configurations and request types, preventing future regressions.How Has This Been Tested?
npm run testinpackages/binding-http.npm run lintandnpm run formatto ensure code quality.Types of changes
Checklist: