Repository navigation
feat: add TYPO3 13.4 LTS support, tests and CI - #51
Merged
Merged
Conversation
- Require TYPO3 ^13.4 and PHP ^8.2 (composer.json, ext_emconf.php) - Register Calculator and Product Finder as CType content elements (list_type plugins are deprecated in TYPO3 13.4) and add the upgrade wizard "eeacomponentsPluginListTypeToCTypeUpdate" for existing content - Replace removed/deprecated APIs: AbstractMessage constants, doc-comment annotations, addPageTSConfig, legacy TCA syntax - Return the redirect response in create/update/delete actions - Fix remaining references to the old extension keys eea_components12 / eea_components (labels, icons, template paths) - Fix asset identifier collision that prevented the calculator script from loading when both components were placed on the same page Tests and CI: - Unit tests for controllers, models, upgrade wizard and metadata consistency (versions and TYPO3/PHP constraints) - Functional tests for plugin/TCA/icon/label registration, frontend rendering of both components and the upgrade wizard - PHPStan level 8 - GitHub Actions: lint, PHPStan, unit and functional tests on PHP 8.2-8.4 with SQLite, MariaDB, MySQL and PostgreSQL Release process: - release-please manifest config with "always-bump-minor", so the major version stays aligned with the TYPO3 major version - Keep the version in ext_emconf.php in sync via release-please - Remove the version field from composer.json (taken from git tags) - Document compatibility and support dates in the README Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The component bundles are .mjs files; load them with type="module". The media server sends "Access-Control-Allow-Origin: *", which cross-origin module scripts require. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the extension installable on TYPO3 13.4 LTS and aligns the versioning with the TYPO3 major version. The next release created by release-please will be 13.1.0.
Note: 13.0.0 (already on Packagist) only supports TYPO3 12.4. This is documented in the README.
TYPO3 13 compatibility
typo3/cms-* ^13.4and PHP^8.2list_typeplugins are deprecated in 13.4 and removed in 14)eeacomponentsPluginListTypeToCTypeUpdatemigrates existing content elements and backend group permissionsAbstractMessageconstants, doc-comment annotations,addPageTSConfig, legacy TCA syntax)Bug fixes
eea_components12/eea_components(backend labels, icons, template paths)eeaComponents, so the calculator script was not loaded when both components were placed on the same pageTests & CI
composer.json,ext_emconf.phpand the release-please manifestcomposer ci). The database jobs and PHP 8.2/8.4 run here in CI for the first time.Release process
always-bump-minor: the major version only changes intentionally via aRelease-As: x.y.zcommit footerext_emconf.phpis updated by release-pleaseversionfield was removed fromcomposer.json(Packagist reads it from the git tag)masterAfter merging / upgrading
Script loading
type="module"(the media server sendsAccess-Control-Allow-Origin: *)🤖 Generated with Claude Code