Skip to content

Split pr check fix into pr ci detective and pr ci fixer #121

Closed

Description

@strawgate
No description provided.

Activity

  1. github-actions commented on Feb 19, 2026

    @github-actions
    Contributor

    Split pr-checks-fix into a read-only pr-ci-detective workflow plus an opt-in pr-ci-fixer workflow so automatic runs only diagnose while fixes require explicit intent.

    Recommendation

    • Create two new workflows: pr-ci-detective (auto on failed CI, add-comment only) and pr-ci-fixer (opt-in, add-comment + push-to-pull-request-branch). Keep pr-checks-fix as a deprecated alias or redirect to pr-ci-detective to avoid breaking existing installs, and update docs + examples to the new names.
    Findings
    • The current workflow is a single pr-checks-fix shim that imports both comment and push safe-outputs (.github/workflows/gh-aw-pr-checks-fix.md:L1-L12) and explicitly instructs the agent to push fixes (.github/workflows/gh-aw-pr-checks-fix.md:L65-L120).
    • The install docs and examples are all named pr-checks-fix (README.md:L24-L31, gh-agent-workflows/README.md:L7-L14, gh-agent-workflows/pr-checks-fix/README.md:L1-L31, gh-agent-workflows/pr-checks-fix/example.yml:L1-L21).
    • The dogfood trigger also points at the single compiled workflow (.github/workflows/trigger-pr-checks-fix.yml:L1-L21).
    Verification

    Not run (triage only).

    Detailed Action Plan
    1. Add new shims in .github/workflows/ per gh-agent-workflows/DEVELOPING.md:L134-L140:
      • gh-aw-pr-ci-detective.md: copy the existing gh-aw-pr-checks-fix.md but drop safe-output-push-to-pr, rename the prompt/title to “PR CI Detective,” and remove push-related instructions.
      • gh-aw-pr-ci-fixer.md: keep safe-output-push-to-pr and update naming to “PR CI Fixer,” emphasizing that fixes are opt-in.
    2. Create new workflow directories:
      • gh-agent-workflows/pr-ci-detective/README.md + example.yml with the current workflow_run trigger, and permissions pared down to contents: read + issues/pull-requests: write.
      • gh-agent-workflows/pr-ci-fixer/README.md + example.yml with an explicit opt-in trigger (e.g., workflow_dispatch with a run_id input or a /ai-style comment command) and contents: write for push.
    3. Decide on backwards compatibility:
      • Either keep pr-checks-fix as a thin wrapper that calls gh-aw-pr-ci-detective.lock.yml, or mark it deprecated in docs while keeping the old files for one release.
    4. Update references in README.md and gh-agent-workflows/README.md to list the two new workflows and remove/annotate PR Checks Fix.
    5. Run make compile to generate new .lock.yml files and updated trigger-*.yml copies, then verify output is clean.
    Related Items
    Type Link Relevance
    Issue #53 Original request to add PR checks fix workflow.
    PR #54 Added pr-checks-fix shim and docs.
    File .github/workflows/gh-aw-pr-checks-fix.md:L1-L120 Current combined detective/fixer prompt and safe-outputs.
    File gh-agent-workflows/pr-checks-fix/README.md:L1-L31 Current consumer-facing docs and safe outputs.
    File gh-agent-workflows/pr-checks-fix/example.yml:L1-L21 Current trigger example.

    What is this? | From workflow: Issue Triage Agent

    Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #121

  2. strawgate commented on Feb 19, 2026

    @strawgate
    ContributorAuthor

    /ai make a pr dont worry about backwards compat

  3. github-actions commented on Feb 19, 2026

    @github-actions
    Contributor

    PR created via automation with title Add PR CI detective and fixer workflows (if it’s not visible yet, please check recent PRs for that title).

    Summary:

    • add pr-ci-detective (read-only, workflow_run) and pr-ci-fixer (workflow_dispatch with workflow-run-id) templates + docs
    • update workflow listings and deprecate pr-checks-fix docs
    • add new shim files under github/workflows for maintainer relocation into .github/workflows and compilation

    Testing:

    • make lint

    What is this? | From workflow: Issue Assistant

    Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions