[product-manager-impersonator] Golden tests for dogfood trigger rewriting #2187

Feature Idea

Summary: Add a small golden-fixture regression test suite for scripts/dogfood.sh so trigger-rewrite behavior is validated before make compile changes land.

Why a Customer Would Want This

Maintainers and contributors rely on make compile during workflow development, and unexpected trigger rewrites create hard-to-debug CI churn. A deterministic regression suite would catch rewrite drift immediately, making workflow authoring safer and faster.

Rough Implementation Sketch

• Add tests/test_dogfood_sync.py with fixture inputs (gh-agent-workflows/*/example.yml, optional dogfood-with.yml, lockfile hints) and expected trigger-*.yml snapshots.
• Run scripts/dogfood.sh in a temp fixture workspace and assert exact output for core cases: existing/missing secrets:, run job with and without with:, and remediation-chain append behavior.
• Add at least one fixture for the known run-job rewrite edge case tracked in [product-manager-impersonator] Dogfood trigger rewrite should not assume run job #2092.
• Wire into the existing pytest path (make test) so regressions fail fast during normal contributor workflows.

Why It Won't Be That Hard

The repository already uses pytest (Makefile) and has script-level tests under tests/, so this is incremental test coverage rather than new infrastructure. The scope is narrow (one script and a handful of fixtures) and should fit in a 1–2 day implementation.

Evidence

• scripts/dogfood.sh performs multiple ordered text transforms and appends (sed/awk/heredoc) during trigger generation (scripts/dogfood.sh L55–L167).
• make compile depends on sync → scripts/dogfood.sh, so rewrite regressions directly affect contributor workflows (Makefile L190–L208).
• Current tests cover other scripts/utilities but there is no dogfood regression test file in tests/.
• Recent activity shows repeated reliability fixes in nearby automation paths (Fix workflow utility scripts to use requests and structural PyYAML edits #2164, Fix timezone-aware --since filtering in fetch-workflow-logs #2159, Propagate dispatch failures in trigger CI script #2143, Fix trigger-ci-workflows exit code on dispatch failures #2128), indicating continued value in guardrail-style tests.
• Related open issue [product-manager-impersonator] Dogfood trigger rewrite should not assume run job #2092 targets one concrete rewrite bug; this proposal is a broader prevention layer to avoid repeats.

What is this? | From workflow: Trigger Product Manager Impersonator

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.