Missing trigger files and pr-review severity mismatch #236

Activity

1. github-actions commented on Feb 20, 2026

   

   github-actionsBot

   on Feb 20, 2026 – with GitHub Actions

   Contributor

   More actions

   tl;dr: I can reproduce the missing external trigger files (real issue), but I cannot reproduce a docs-pr-review severity input mismatch in current main because both docs and workflow source use minimum_severity.

   Recommendation

   1. Regenerate and commit the two missing trigger files: .github/workflows/trigger-docs-drift-external.yml and .github/workflows/trigger-docs-new-contributor-review-external.yml.
   2. Treat the docs-pr-review naming mismatch as already resolved on main; if there is still a docs mismatch, please point to the exact file/path because current repo state is consistent.

   Findings

   • scripts/dogfood.sh:27-45 copies every gh-agent-workflows/*/example.yml to .github/workflows/trigger-*.yml except explicit excludes in scripts/dogfood.sh:20-23 (flaky-test-triage, issue-triage-pr).
   • gh-agent-workflows/docs-drift-external/example.yml and gh-agent-workflows/docs-new-contributor-review-external/example.yml exist, and are not in the exclusion list.
   • Tracked external triggers are currently absent (git ls-files .github/workflows/trigger-*external*.yml returned no tracked files).
   • Running ./scripts/dogfood.sh generated both missing files locally.
   • gh-agent-workflows/docs-pr-review/README.md:37 documents minimum_severity.
   • .github/workflows/gh-aw-docs-pr-review.md:35 defines minimum_severity input, and .github/workflows/gh-aw-docs-pr-review.md:192 references inputs.minimum_severity.
   • Related history:
     • Add an input for minimum PR Review comment severity #48 (closed) requested minimum severity support.
     • Add signal/noise controls for PR Review Workflows #49 (closed) requested signal/noise controls.
     • PR Add minimum severity threshold for PR review comments #51 implemented minimum severity threshold behavior.
     • PR Improve docs-drift and docs-new-contributor-review workflows #211 introduced the external docs workflows split.

   Verification

   I ran the following checks:

   $ ./scripts/dogfood.sh
   ...
   ✓ gh-agent-workflows/docs-drift-external/example.yml → .github/workflows/trigger-docs-drift-external.yml
   ✓ gh-agent-workflows/docs-new-contributor-review-external/example.yml → .github/workflows/trigger-docs-new-contributor-review-external.yml
   

   $ git ls-files .github/workflows/trigger-*external*.yml
   # (no output)
   

   $ rg -n "minimum[-_]severity" gh-agent-workflows/docs-pr-review/README.md
   37:| `minimum_severity` | ... |
   
   $ rg -n "minimum[-_]severity" .github/workflows/gh-aw-docs-pr-review.md
   35:      minimum_severity:
   192:- **Minimum inline severity**: `$\{\{ inputs.minimum_severity }}`
   

   Detailed Action Plan

   1. Run ./scripts/dogfood.sh from repo root.
   2. Stage only the missing generated files:
      • .github/workflows/trigger-docs-drift-external.yml
      • .github/workflows/trigger-docs-new-contributor-review-external.yml
   3. Confirm no unintended trigger churn before commit (other triggers may update due current generation state).
   4. In the same PR description, note that docs-pr-review already uses minimum_severity consistently and include references:
      • gh-agent-workflows/docs-pr-review/README.md:37
      • .github/workflows/gh-aw-docs-pr-review.md:35
   5. Optional hardening: add a CI check that fails when ./scripts/dogfood.sh produces diffs in .github/workflows/trigger-*.yml to prevent future drift.

   Related Items

   Type	Link	Relevance
   Issue	#236	Current triage target
   Issue	#48	Prior request for minimum severity support
   Issue	#49	Prior signal/noise control request
   PR	#51	Implemented minimum severity threshold behavior
   PR	#211	Split/added external docs workflows
   File	scripts/dogfood.sh:20-23	Exclusion list for dogfood trigger generation
   File	scripts/dogfood.sh:27-45	Trigger generation logic
   File	gh-agent-workflows/docs-pr-review/README.md:37	minimum_severity documented
   File	.github/workflows/gh-aw-docs-pr-review.md:35	minimum_severity workflow input

   ---

   What is this? | From workflow: Issue Triage Agent

   Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #236
2. strawgate

   closed this as completedon Feb 21, 2026