Skip to content

Improve defaults for close older issues #357

Closed

Description

@strawgate

For certain reports closing the last report makes sense, for lots of auditor/detector workflows it does not

Activity

  1. github-actions commented on Feb 21, 2026

    @github-actions
    Contributor

    This issue looks like a duplicate of #354 and may be safe to close.

    Possible duplicates:


    What is this? | From workflow: Duplicate Issue Detector

    Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

  2. github-actions commented on Feb 21, 2026

    @github-actions
    Contributor

    TL;DR: #355 solves configurability, but the default should be split by workflow type (keep true for “single rolling report” workflows, switch to false for most detector/auditor workflows) to avoid auto-closing distinct findings.

    Recommendation

    Update PR #355 (or a follow-up) to use workflow-specific defaults instead of default: true everywhere. I recommend:

    • Default false for detector/auditor-style workflows (gh-aw-text-auditor, gh-aw-code-duplication-detector, gh-aw-breaking-change-detector, gh-aw-bug-hunter, gh-aw-docs-patrol*, gh-aw-flaky-test-investigator, gh-aw-newbie-contributor-patrol*, and likely gh-aw-scheduled-audit).
    • Keep default true for “rolling status” workflows where only the latest report is usually desired (gh-aw-project-summary, gh-aw-performance-profiler, gh-aw-stale-issues, gh-aw-downstream-health, gh-aw-agent-suggestions).
    Findings
    Verification

    I verified current behavior and PR direction with repo scans and PR file inspection:

    $ rg -n "close-older-issues\s*:" .github/workflows
    ... gh-aw-scheduled-audit.md:85:    close-older-issues: true
    ... gh-aw-project-summary.md:78:    close-older-issues: true
    ... gh-aw-text-auditor.md:102:    close-older-issues: true
    ... (19 workflow files total; most scheduled report workflows are `true`)
    
    $ python (scan PR #355 get_files payload patches)
    .github/workflows/gh-aw-agent-suggestions.md default_true_added= True
    .github/workflows/gh-aw-breaking-change-detector.md default_true_added= True
    ...
    .github/workflows/gh-aw-text-auditor.md default_true_added= True
    Detailed Action Plan
    1. In .github/workflows/gh-aw-*.md files touched by Make close-older-issues configurable for scheduled report workflows #355, keep close-older-issues as an input but change default: per workflow intent (detector/auditor vs rolling summary).
    2. Regenerate lock files (make compile) so GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG reflects the new defaults in .lock.yml outputs.
    3. Update README input tables for each affected workflow in gh-agent-workflows/*/README.md to document default behavior and when to override.
    4. Add one short policy note in gh-agent-workflows/scheduled-audit/README.md clarifying default selection guidance (“open historical findings” vs “single latest report”).
    5. Validate with make lint-workflows and spot-check compiled lock files for representative workflows.
    Related Items
    Type Link Relevance
    Issue #357 Current request: improve defaults
    Issue #354 Earlier request: make configurable
    PR #355 Implements configurability; currently defaults all to true
    File .github/workflows/gh-aw-scheduled-audit.md:85 Base scheduled audit currently auto-closes older issues
    File .github/workflows/gh-aw-project-summary.md:78 Example workflow where true default is likely still appropriate
    File .github/workflows/agent-deep-dive.md:59 Existing precedent for close-older-issues: false

    What is this? | From workflow: Issue Triage

    Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions