Skip to content

Add report-failed-jobs configuration support to PR Buildkite Detective - #1945

Merged
v1v merged 3 commits into
mainfrom
copilot/support-report-failed-jobs
Aug 28, 2026
Merged

Add report-failed-jobs configuration support to PR Buildkite Detective#1945
v1v merged 3 commits into
mainfrom
copilot/support-report-failed-jobs

Conversation

Copilot AI commented Aug 28, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Implements report-failed-jobs configuration support as specified in the gh-aw glossary reference, following the pattern established in PR #1397 for report-failure-as-issue.

Changes

  • Workflow input: Added report-failed-jobs boolean input to gh-aw-estc-pr-buildkite-detective.md (default: false)
  • Wiring script: Added scripts/wire-report-failed-jobs-input.sh to replace hardcoded GH_AW_REPORT_FAILED_JOBS: "true" with dynamic expression ${{ inputs.report-failed-jobs && 'true' || 'false' }} in eligible compiled lock files
  • Build pipeline: Updated Makefile to execute the new wiring script during compilation
  • Documentation: Updated the ESTC PR Buildkite Detective README with the new input parameter

Result

The workflow now exposes report-failed-jobs as a configurable input, disabled by default for gh-aw-estc-pr-buildkite-detective:

jobs:
  run:
    uses: elastic/ai-github-actions/.github/workflows/gh-aw-estc-pr-buildkite-detective.lock.yml@v0
    with:
      report-failed-jobs: true  # Optional: enable failed job reporting

The wiring script only updates compiled lock files that already define the report-failed-jobs input, leaving unrelated workflows unchanged.

The body of this PR is automatically managed by the Trigger Update PR Body workflow.

Copilot AI assigned Copilot and v1v Aug 28, 2026
Copilot AI linked an issue Aug 28, 2026 that may be closed by this pull request
Support https://github.github.com/gh-aw/reference/glossary/#report-failed-jobs-report-failed-jobs #1942
Closed
@v1v
Support report-failed-jobs configuration
20cb711 
- Add report-failed-jobs input to gh-aw-estc-pr-buildkite-detective.md (default: false)
- Create wire-report-failed-jobs-input.sh script to wire input to GH_AW_REPORT_FAILED_JOBS
- Update Makefile to run new wiring script during compilation
- Update README documentation for the new input
- Recompile all workflows with the new changes

Co-authored-by: v1v <2871786+v1v@users.noreply.github.com>
Copilot AI changed the title [WIP] Support report failed jobs in GH Agentic Workflows Add report-failed-jobs configuration support to PR Buildkite Detective Aug 28, 2026
Copilot finished work on behalf of v1v August 28, 2026 10:14
Copilot AI requested a review from v1v August 28, 2026 10:14
@v1v v1v mentioned this pull request Aug 28, 2026
Closed
@v1v
v1v marked this pull request as ready for review August 28, 2026 10:29
@github-actions github-actions Bot mentioned this pull request Aug 28, 2026
Closed
@github-actions github-actions Bot added the medium_boom Medium PR blast radius; likely benefits from human review label Aug 28, 2026
@v1v
v1v requested a review from fr4nc1sc0-r4m0n August 28, 2026 10:45
@fr4nc1sc0-r4m0n

fr4nc1sc0-r4m0n commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Should we use a single input flag to deactivate agent and job failures? I feel like It seems a little bit redundant. WDYT @v1v ?

@v1v

v1v commented Aug 28, 2026

Copy link
Copy Markdown
Member

Should we use a single input flag to deactivate agent and job failures? I feel like It seems a little bit redundant. WDYT @v1v ?

Good idea, I thought about it but wasn't sure if it was worthy to use another input here.

I'll ask copilot to do it

@copilot let's honour report-failure-as-issue instead of creating a new input.

@v1v
Use report-failure-as-issue for both agent and job failures
f396095 
- Remove separate report-failed-jobs input (redundant)
- Update report-failure-as-issue description to cover both agent and job failures
- Wire GH_AW_REPORT_FAILED_JOBS to report-failure-as-issue input
- Update wire-report-failure-input.sh to handle both env vars
- Remove wire-report-failed-jobs-input.sh script (no longer needed)
- Update Makefile to remove redundant script call
- Update documentation to reflect unified control

Co-authored-by: v1v <2871786+v1v@users.noreply.github.com>

Copilot AI commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Should we use a single input flag to deactivate agent and job failures? I feel like It seems a little bit redundant. WDYT @v1v ?

Good idea, I thought about it but wasn't sure if it was worthy to ...

Done! I've updated the implementation to use the existing report-failure-as-issue input for both agent failures and failed job reporting.

Changes in commit b5e5a90:

  • Removed the redundant report-failed-jobs input
  • Updated report-failure-as-issue description to cover both types of failures
  • Both GH_AW_FAILURE_REPORT_AS_ISSUE and GH_AW_REPORT_FAILED_JOBS now wire to the same input
  • Simplified the build pipeline by removing the separate wiring script

The default remains true, and users can now control both with a single flag.

Copilot finished work on behalf of v1v August 28, 2026 11:15
fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n approved these changes Aug 28, 2026
View reviewed changes

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v
v1v merged commit ead46b7 into main Aug 28, 2026
26 checks passed
@v1v
v1v deleted the copilot/support-report-failed-jobs branch August 28, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n approved these changes
@v1v v1v Awaiting requested review from v1v

Assignees

@v1v v1v

Copilot code review Copilot

Labels

medium_boom Medium PR blast radius; likely benefits from human review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support https://github.github.com/gh-aw/reference/glossary/#report-failed-jobs-report-failed-jobs

3 participants

@fr4nc1sc0-r4m0n @v1v