Repository navigation
Fix silently dropped PR-review MCP tool: rename safe-inputs → mcp-scripts, bump gh-aw to v0.87.10 - #1974
Conversation
…lock files Co-authored-by: v1v <2871786+v1v@users.noreply.github.com>
|
@copilot resolve the merge conflicts in this pull request and also run the make goals require to compile the workflows too |
…-agent-issues # Conflicts: # .github/aw/actions-lock.json # .github/workflows/gh-aw-dependency-review.lock.yml # .github/workflows/gh-aw-issue-fixer.lock.yml # .github/workflows/gh-aw-issue-triage.lock.yml Co-authored-by: v1v <2871786+v1v@users.noreply.github.com>
Co-authored-by: v1v <2871786+v1v@users.noreply.github.com>
Merged |
|
/ai analyse what it hactually change between v0.87.10 and v0.87.5 and provide some deeper analyses if any contract or something along those lines need to be taking into account |
|
@copilot analyse what it actually changed between v0.87.10 and v0.87.5 and provide some deeper analyses if any contract or something along those lines need to be taking into account |
Analysis of Schema/contract changes that could affect authored workflows:
Reliability/bug fixes relevant to our workflows:
No schema/contract change directly required the Verification performed: all 57 workflows recompiled cleanly with |
The
ready_to_code_review,ready_to_make_pr, andready_to_push_to_prhelper tools were defined under asafe-inputs:frontmatter key, which gh-aw renamed tomcp-scripts:upstream some time ago. The current compiler no longer recognizessafe-inputs:and silently drops it, so the tools never get registered — even though the agent prompts still instruct the model to call them. This causes the PR review agent to fall back to anoop("tool unavailable") instead of actually reviewing.Fragment fix
safe-inputs:→mcp-scripts:in the 3 affected fragments (same schema, key rename only):safe-output-create-pr.mdsafe-output-code-review.mdsafe-output-push-to-pr.mdCompiler bump
GH_AW_VERSION/GH_AW_BUILD_VERSION/GH_AW_COMPAT_VERSIONfromv0.87.5→v0.87.10in theMakefilefor other upstream reliability fixes.Recompiled artifacts
.lock.ymlworkflow files viamake compile.mcpscriptsMCP server entry now listsready-to-code-reviewin the compiled manifest, where before the tool was absent entirely.Test fixture
Updated
tests/test_safe_input_ready_to_make_pr.py, which read fragment frontmatter viafrontmatter["safe-inputs"], to usefrontmatter["mcp-scripts"]matching the renamed key.Fixes PR review agent has been silently skipping reviews for months #1972
The body of this PR is automatically managed by the workflow runtime.
The body of this PR is automatically managed by the Trigger Update PR Body workflow.