Skip to content

Fix workflow trigger stability and composite action lint coverage - #2235

Draft
github-actions[bot] wants to merge 1 commit into
mainfrom
fix-2234-stable-workflow-targets-630b8f4e45859c2a
Draft

github-actions[bot] wants to merge 1 commit into
mainfrom
fix-2234-stable-workflow-targets-630b8f4e45859c2a

Conversation

@github-actions

@github-actions github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR resolves #2234 by making CI workflow dispatching resilient to workflow rename changes and by expanding composite action validation coverage.

What changed

  • Updated scripts/trigger-ci-workflows.sh to dispatch by workflow file name instead of mutable display name.
  • Replaced stale monitor target Trigger Estc Downstream Health with trigger-internal-downstream-health.yml.
  • Added target existence validation in the script (.github/workflows/<file>), so missing/renamed targets fail clearly.
  • Updated Makefile lint-actions target to discover all tracked action.yml/action.yaml files via git ls-files, including .github/actions/**.

Validation

bash scripts/trigger-ci-workflows.sh --list
bash scripts/trigger-ci-workflows.sh --dry-run monitors
make lint-actions
make compile && make lint

Pre-Completion Checklist

  • Re-read the issue/request and confirmed this PR directly addresses it
  • Reviewed all changed files for correctness
  • Ran make compile and make lint with no errors
  • Verified no unrelated files were modified

Closes #2234.


What is this? | From workflow: Trigger Framework Best Practices

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Use workflow file names for gh workflow dispatch to avoid breakage from workflow name renames, including the internal downstream health workflow rename. Add file-existence validation for declared workflow targets.

Expand lint-actions discovery to validate every tracked action.yml/action.yaml file, including .github/actions composites.

Closes #2234

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[framework-best-practices] Use stable workflow identifiers and complete action discovery in CI trigger/lint scripts

0 participants