[Cloud Asset Inventory] Fix entity.attribute mapping bug by renaming it to entity.Details - #7473
Merged
kubasobon merged 2 commits intoJul 23, 2026
Conversation
1 task
Re-align the Entity struct fields; renaming Attributes (10 chars) to Details (7 chars) shortened the longest field name, so gofmt/gci flagged the stale column padding in internal/inventory/asset.go.
olegsu
approved these changes
Jul 23, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
kubasobon
added a commit
that referenced
this pull request
Jul 27, 2026
…pping bug by renaming it to entity.Details (#7474) ### Summary of your changes For: #incident-3395-failing-quality-gate-for-entity-store-synthetics Incident Slack: https://elastic.slack.com/archives/C0BJQCSBT47 Publishing asset details as `entity.attributes` breaks Entity Store extraction. This, along with related integrations PR, fixes the issue by using `entity.Details` instead. Integrations PR contains an ingest pipeline that ensures even old Cloudbeat versions that publish `entity.attributes` get remapped to `Details`. This allows extraction to work as intended. ### Related Issues Towards https://github.com/elastic/security-team/issues/18408 <hr>This is an automatic backport of pull request #7473 done by [Mergify](https://mergify.com). Co-authored-by: Kuba Soboń <wtty.fool@gmail.com>
kubasobon
added a commit
that referenced
this pull request
Jul 30, 2026
…7277) ### Summary of your changes > [!NOTE] > **Stacked on #7473.** This PR is based on `asset-inventory/fix-entity-attributes`, which renames the `entity.attributes` (flattened) bag to `entity.Details` to fix the Entity Store generic-extraction bug. All new fields below are therefore emitted under **`entity.Details.*`** (not `entity.attributes.*`). Please review/merge #7473 first; this PR's diff shows only the InfoSec fetcher changes on top of it. | Resource | Field | Change | | -------------------- | --------------------------------- | ------------------------------------------------------------------------------------------------------------------------ | | **EC2** | `entity.Details.Role` | Added `LookupTag(tags, "role")` in `buildDetails` | | **RDS** | `entity.Details.DBInstanceStatus` | Added `Status` field to wrapper struct; mapped from `DBInstanceStatus` in provider; emitted in fetcher | | **ELB v2** (ALB/NLB) | `entity.Details.IPAddresses` | `GetIPAddresses()` now also collects `PrivateIPv4Address` and `IPv6Address` per AZ address (previously only `IpAddress`) | | **ELB v1** (Classic) | `entity.Details.State` | `GetState()` returns `"active"` (hardcoded as classic API exposes no state field) | | **ELB v1** (Classic) | `entity.Details.IPAddresses` | DNS-resolves the ELB `DNSName` at fetch time via injectable `hostResolver`; soft-fails to empty on error | ### Related Issues Closes elastic/security-team#18294 ### Checklist - [x] I have added tests that prove my fix is effective or that my feature works
Merged
1 task
kubasobon
added a commit
that referenced
this pull request
Aug 3, 2026
…fetchers for InfoSec (#7482) ### Summary of your changes > [!NOTE] > **Stacked on #7473.** This PR is based on `asset-inventory/fix-entity-attributes`, which renames the `entity.attributes` (flattened) bag to `entity.Details` to fix the Entity Store generic-extraction bug. All new fields below are therefore emitted under **`entity.Details.*`** (not `entity.attributes.*`). Please review/merge #7473 first; this PR's diff shows only the InfoSec fetcher changes on top of it. | Resource | Field | Change | | -------------------- | --------------------------------- | ------------------------------------------------------------------------------------------------------------------------ | | **EC2** | `entity.Details.Role` | Added `LookupTag(tags, "role")` in `buildDetails` | | **RDS** | `entity.Details.DBInstanceStatus` | Added `Status` field to wrapper struct; mapped from `DBInstanceStatus` in provider; emitted in fetcher | | **ELB v2** (ALB/NLB) | `entity.Details.IPAddresses` | `GetIPAddresses()` now also collects `PrivateIPv4Address` and `IPv6Address` per AZ address (previously only `IpAddress`) | | **ELB v1** (Classic) | `entity.Details.State` | `GetState()` returns `"active"` (hardcoded as classic API exposes no state field) | | **ELB v1** (Classic) | `entity.Details.IPAddresses` | DNS-resolves the ELB `DNSName` at fetch time via injectable `hostResolver`; soft-fails to empty on error | ### Related Issues Closes https://github.com/elastic/security-team/issues/18294 ### Checklist - [x] I have added tests that prove my fix is effective or that my feature works <hr>This is an automatic backport of pull request #7277 done by [Mergify](https://mergify.com). Co-authored-by: Kuba Soboń <wtty.fool@gmail.com>
kubasobon
added a commit
that referenced
this pull request
Sep 8, 2026
…7277) ### Summary of your changes > [!NOTE] > **Stacked on #7473.** This PR is based on `asset-inventory/fix-entity-attributes`, which renames the `entity.attributes` (flattened) bag to `entity.Details` to fix the Entity Store generic-extraction bug. All new fields below are therefore emitted under **`entity.Details.*`** (not `entity.attributes.*`). Please review/merge #7473 first; this PR's diff shows only the InfoSec fetcher changes on top of it. | Resource | Field | Change | | -------------------- | --------------------------------- | ------------------------------------------------------------------------------------------------------------------------ | | **EC2** | `entity.Details.Role` | Added `LookupTag(tags, "role")` in `buildDetails` | | **RDS** | `entity.Details.DBInstanceStatus` | Added `Status` field to wrapper struct; mapped from `DBInstanceStatus` in provider; emitted in fetcher | | **ELB v2** (ALB/NLB) | `entity.Details.IPAddresses` | `GetIPAddresses()` now also collects `PrivateIPv4Address` and `IPv6Address` per AZ address (previously only `IpAddress`) | | **ELB v1** (Classic) | `entity.Details.State` | `GetState()` returns `"active"` (hardcoded as classic API exposes no state field) | | **ELB v1** (Classic) | `entity.Details.IPAddresses` | DNS-resolves the ELB `DNSName` at fetch time via injectable `hostResolver`; soft-fails to empty on error | ### Related Issues Closes elastic/security-team#18294 ### Checklist - [x] I have added tests that prove my fix is effective or that my feature works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of your changes
For: #incident-3395-failing-quality-gate-for-entity-store-synthetics
Incident Slack: https://elastic.slack.com/archives/C0BJQCSBT47
Publishing asset details as
entity.attributesbreaks Entity Store extraction. This, along with related integrations PR, fixes the issue by usingentity.Detailsinstead. Integrations PR contains an ingest pipeline that ensures even old Cloudbeat versions that publishentity.attributesget remapped toDetails. This allows extraction to work as intended.Related Issues
Towards https://github.com/elastic/security-team/issues/18408