Skip to content

Add a missing fastboot dependencies whitelist entry. - #113

Merged
xg-wang merged 1 commit into
ember-cli:masterfrom
cvx:fix-fastboot-whitelist
May 18, 2018
Merged

Add a missing fastboot dependencies whitelist entry.#113
xg-wang merged 1 commit into
ember-cli:masterfrom
cvx:fix-fastboot-whitelist

Conversation

@cvx

@cvx cvx commented May 18, 2018

Copy link
Copy Markdown
Contributor

Fixes an error (introduced in #112) that occurs whenever a fastboot-enabled app that uses ember-fetch tries to handle a request:

There was an error running your app in fastboot. More info about the error:
 Error: Unable to require module 'abortcontroller-polyfill/dist/cjs-ponyfill' because it was not in the whitelist.
    at Object.require (/app/node_modules/fastboot/src/ember-app.js:133:15)
    at Module.callback (/app/tmp/broccoli_merge_trees-output_path-76mgNO0Y.tmp/ember-fetch/fastboot-fetch.js:4:44)

Comment thread package.json Outdated
"fastbootDependencies": [
"node-fetch",
"abortcontroller-polyfill"
"abortcontroller-polyfill",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to delete this line

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Changed, tested, and updated the PR. Thanks!

@cvx
cvx force-pushed the fix-fastboot-whitelist branch from aa91257 to f4ed8d0 Compare May 18, 2018 14:34
@xg-wang
xg-wang merged commit 78e2691 into ember-cli:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants