Lazy router setup in non-application tests

[xg-wang]

During non setupApplicationTests type tests, the Router being injected into service:router and service:routing does not start routing, in which it initializes its _routerMicrolib. Calling public API on service:router will throw in those tests.

This commit will trigger startRouting on router, in non application tests the router service should just work™.

Link tested on xg-wang/__router-test@df28714. It fails on travis-ci.

Fixes #16831

[rwjblue]

I’m not sure this is the right direction. IMHO, tests that need the router (e.g. those testing generated href’s or things using the router service) should call this.owner.setupRouter() explicitly in the test.

[xg-wang]

Can you explain the reason behind this? I think if using router service in a component is not discouraged the test experience should also be out-of-box.

[rwjblue]

Hmm, @xg-wang I think I've made a mistake here, sorry for the double speak (between #16831 (comment) and my comments here). What do you think about reviving these changes?

[nlfurniss]

Is it better to handle this here or to call this.owner.setupRouter() in setupRenderingTest?

[rwjblue]

Is it better to handle this here or to call this.owner.setupRouter()insetupRenderingTest`?

IMHO, most rendering tests aren't going to need the router. So eagerly setting it up in all tests is a bit wasteful.