Repository navigation
[FEATURE] Implement injection parameter normalization RFC. - #17858
Merged
Merged
Conversation
pzuraq
force-pushed
the
feat/classic-class-owner-tunnel
branch
from
April 4, 2019 20:01
791b80b to
8007793
Compare
Closed
rwjblue
force-pushed
the
feat/classic-class-owner-tunnel
branch
from
May 3, 2019 00:53
8007793 to
7f112e0
Compare
rwjblue
changed the title
Member
|
Just updated to more closely match emberjs/rfcs#451, should be ready for review. |
rwjblue
force-pushed
the
feat/classic-class-owner-tunnel
branch
from
May 3, 2019 14:01
7f112e0 to
0b47cd2
Compare
2 of 3 tasks
chadhietala
suggested changes
May 7, 2019
chadhietala
left a comment
chadhietala
left a comment
Contributor
There was a problem hiding this comment.
Overall this looks good to me. Just a small nit.
|
|
||
| let PASSED_FROM_CREATE; | ||
| let initCalled; // only used in debug builds to enable the proxy trap | ||
| const initCalled = DEBUG ? new WeakSet() : undefined; // only used in debug builds to enable the proxy trap |
Contributor
There was a problem hiding this comment.
I believe you are going to fail IE11 builds due to the usage of WeakSet.
Member
There was a problem hiding this comment.
@chadhietala - WeakSet is imported from @ember/polyfills (which uses a WeakMap with a boolean value when an actual WeakSet is not present).
rwjblue
approved these changes
May 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements emberjs/rfcs#451, and fixes the error message so it won't throw if properties aren't passed (
new EmberObject())