Skip to content

Opinionated docker build - #783

Merged
altendky merged 14 commits into
ericaltendorf:developmentfrom
graemes:development
Jun 27, 2021
Merged

Opinionated docker build#783
altendky merged 14 commits into
ericaltendorf:developmentfrom
graemes:development

Conversation

@graemes

@graemes graemes commented Jun 13, 2021

Copy link
Copy Markdown
Contributor

This is a 'opinionated' docker build. It:

  • utilises a multi-stage build to minimise space & potential security issues ;
  • uses an internal user/group id which should be mapped to a user/group on the host (all bound directories should be owned by this user. Again this is for process isolation for security ;
  • runs 'plotman plot' on startup ;

@altendky altendky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to go over this in more detail in a few different areas, but here's a start to the conversation. Thanks for the work here and my apologies for the delay in getting to it.

Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread build-docker-plotman.sh Outdated
Comment thread build-docker-plotman.sh Outdated

@altendky altendky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write up a 'how to use this' in the wiki? Or just start with a less "formal" comment here or whatever. I'm thinking there's some setup for the volumes?

Comment thread Dockerfile
@altendky

Copy link
Copy Markdown
Collaborator

Oops, and a changelog entry.

@altendky
altendky merged commit 94b6461 into ericaltendorf:development Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants