Skip to content

TestConnectServer reply carries no engine discriminator #3244

Closed

Description

@erikdarlingdata

Spun out of the #3145 close-out (PR #3149).

Current state: the TestConnectServer reply carries no engine discriminator. Today that is why the two probe-fed dialog render sites cannot be reached with a PostgreSQL payload at all, so nothing wrong renders there; #3149's call-site audit verified this and left them alone.

Why it matters: it is a latent trap. The moment test-connect learns to probe a PostgreSQL target, its reply cannot say which version vocabulary its number belongs to, and 17 is a real major in both engines, so a consumer guessing the engine would be silently believed. That exact failure mode is why MonitoredEngineVersion.DescribeEngineVersion takes the two majors as separate parameters.

Fix shape: add the engine kind (and a PostgreSQL major, populated on that arm) to the TestConnectServer reply, and feed the shared engine-facts reader that #3149 gave the probe-fed dialogs. Do this as part of, or as a prerequisite for, whatever change first teaches test-connect about PostgreSQL targets.

Activity

  1. added a commit that references this issue on Sep 10, 2026
  2. erikdarlingdata commented on Sep 10, 2026

    @erikdarlingdata
    OwnerAuthor

    Fixed by PR #3256 (test-connect request names the engine; probe reply's engine facts pinned), merged to dev at f60b245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions