You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
TestConnectServer reply carries no engine discriminator #3244
Current state: the TestConnectServer reply carries no engine discriminator. Today that is why the two probe-fed dialog render sites cannot be reached with a PostgreSQL payload at all, so nothing wrong renders there; #3149's call-site audit verified this and left them alone.
Why it matters: it is a latent trap. The moment test-connect learns to probe a PostgreSQL target, its reply cannot say which version vocabulary its number belongs to, and 17 is a real major in both engines, so a consumer guessing the engine would be silently believed. That exact failure mode is why MonitoredEngineVersion.DescribeEngineVersion takes the two majors as separate parameters.
Fix shape: add the engine kind (and a PostgreSQL major, populated on that arm) to the TestConnectServer reply, and feed the shared engine-facts reader that #3149 gave the probe-fed dialogs. Do this as part of, or as a prerequisite for, whatever change first teaches test-connect about PostgreSQL targets.
Activity
Merge pull request #3256 from erikdarlingdata/fix/3244-testconnect-en…
erikdarlingdata commentedon Sep 10, 2026
Fixed by PR #3256 (test-connect request names the engine; probe reply's engine facts pinned), merged to dev at f60b245.
Name the engine on the test-connect request and pin the probe reply's…
Add the release wave's CHANGELOG entries in one splice (erikdarlingda…
The Add Server dialog can say PostgreSQL (#3499) (#3504)