You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Procedures grid plots logical reads under the physical-reads label, and two slicer labels call totals averages (#3547 siblings) #3556
Two verified sibling defects of #3547 in Lite's grid sorting handlers (Lite\Controls\ServerTab.Grids.cs), found during the #3547 work and confirmed by grep:
1. The procedures grid plots logical reads under a physical-reads label (:417): "TotalPhysicalReads" => ("TotalReads", "Total Physical Reads") — the exact #3547 bug one grid over: the physical sort maps to the logical aggregate and the value switch has no physical case. The QueryStore grid's fixed mapping (:324/:343, PR #3550) is the pattern to mirror; check whether the procedures slicer's source SELECT carries physical reads and thread it through the same way if absent (the #3550 timeline commit is the template).
2. Slice totals plotted under "Avg" labels (:369-370): "AvgLogicalReads" => ("TotalReads", "Avg Reads") and "AvgLogicalWrites" => ("TotalWrites", "Avg Writes") — the plotted bucket values are execution-weighted slice totals, so the labels under-claim what the bars show. Honest labels ("Total Reads"/"Total Writes", matching the #3550 precedent) or truly-average values; label fix preferred per the #3547 resolution.
From the 2026-09 brains-review wave (found in-flight during #3547; verified by grep before filing). Pinning: extend the ParitySource regex-pin pattern used by QueryStoreSlicerMetricMapTests to cover the procedures switch.
Activity
Darling viewer: port the #3547/#3556 grid fixes the review found unpo…
Procedures slicer plots the physical series on a physical sort; Query…
CHANGELOG: the brains-review wave, one splice (17 entries) (#3568)
erikdarlingdata commentedon Sep 18, 2026
Fixed on dev in PR #3567 (2026-09 brains-review wave). Closing per the dev-merge convention; the fix reaches main with the next release cut.